Skip to content

Commit e61ca43

Browse files
Updates the default adoprovider and description for sqlserver (DataDog#21364)
* Updates the default adoprovider and description for sqlserver * sync config file * Add changelog * sync config models --------- Co-authored-by: Eric Weaver <eweaver755@gmail.com> Co-authored-by: Eric Weaver <eric.weaver@datadoghq.com>
1 parent f26494f commit e61ca43

4 files changed

Lines changed: 7 additions & 8 deletions

File tree

sqlserver/assets/configuration/spec.yaml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -482,14 +482,13 @@ files:
482482
type: string
483483
- name: adoprovider
484484
description: |
485-
Choose the ADO provider. Note that the (default) provider
486-
SQLOLEDB is being deprecated. To use the newer MSOLEDBSQL
485+
Choose the ADO provider. Note that SQLOLEDB is deprecated. To use the MSOLEDBSQL
487486
provider, set the adoprovider to "MSOLEDBSQL" below or "MSOLEDBSQL19" for version 19 of the driver.
488487
You will also need to download the new provider from
489488
https://docs.microsoft.com/en-us/sql/connect/oledb/oledb-driver-for-sql-server?view=sql-server-2017
490489
value:
491490
type: string
492-
example: SQLOLEDB
491+
example: MSOLEDBSQL
493492
- name: connector
494493
description: |
495494
Change the connection method from adodbapi (the default) to

sqlserver/changelog.d/21364.fixed

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Clarifies the default ADO provider in conf.yaml.example

sqlserver/datadog_checks/sqlserver/config_models/defaults.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ def shared_propagate_agent_tags():
1313

1414

1515
def instance_adoprovider():
16-
return 'SQLOLEDB'
16+
return 'MSOLEDBSQL'
1717

1818

1919
def instance_autodiscovery_db_service_check():

sqlserver/datadog_checks/sqlserver/data/conf.yaml.example

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -328,14 +328,13 @@ instances:
328328
#
329329
# db_fragmentation_object_names: []
330330

331-
## @param adoprovider - string - optional - default: SQLOLEDB
332-
## Choose the ADO provider. Note that the (default) provider
333-
## SQLOLEDB is being deprecated. To use the newer MSOLEDBSQL
331+
## @param adoprovider - string - optional - default: MSOLEDBSQL
332+
## Choose the ADO provider. Note that SQLOLEDB is deprecated. To use the MSOLEDBSQL
334333
## provider, set the adoprovider to "MSOLEDBSQL" below or "MSOLEDBSQL19" for version 19 of the driver.
335334
## You will also need to download the new provider from
336335
## https://docs.microsoft.com/en-us/sql/connect/oledb/oledb-driver-for-sql-server?view=sql-server-2017
337336
#
338-
# adoprovider: SQLOLEDB
337+
# adoprovider: MSOLEDBSQL
339338

340339
## @param connector - string - optional - default: adodbapi
341340
## Change the connection method from adodbapi (the default) to

0 commit comments

Comments
 (0)