Skip to content

Commit eb0af3b

Browse files
authored
Use 8080 as the default metrics port and fix docs references (DataDog#22860)
* Fix default metrics port * Add changelog line
1 parent 4f9e047 commit eb0af3b

7 files changed

Lines changed: 9 additions & 8 deletions

File tree

karpenter/assets/configuration/spec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ files:
1010
options:
1111
- template: instances/openmetrics
1212
overrides:
13-
openmetrics_endpoint.value.example: http://localhost:8000/metrics
13+
openmetrics_endpoint.value.example: http://localhost:8080/metrics
1414
openmetrics_endpoint.description: |
1515
Endpoint exposing the Karpenter's Prometheus metrics. For more information refer to:
16-
https://karpenter.sh/docs/concepts/metrics/
16+
https://karpenter.sh/docs/reference/metrics/

karpenter/changelog.d/22860.fixed

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Use `8080` as the default metrics port and fix docs references

karpenter/datadog_checks/karpenter/config_models/validators.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ def initialize_instance(values, **kwargs):
99
validate_url(
1010
values['openmetrics_endpoint'],
1111
required_path='/metrics',
12-
example='http://localhost:8000/metrics',
12+
example='http://localhost:8080/metrics',
1313
config='openmetrics_endpoint',
1414
)
1515

karpenter/datadog_checks/karpenter/data/conf.yaml.example

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,9 @@ instances:
4747

4848
## @param openmetrics_endpoint - string - required
4949
## Endpoint exposing the Karpenter's Prometheus metrics. For more information refer to:
50-
## https://karpenter.sh/docs/concepts/metrics/
50+
## https://karpenter.sh/docs/reference/metrics/
5151
#
52-
- openmetrics_endpoint: http://localhost:8000/metrics
52+
- openmetrics_endpoint: http://localhost:8080/metrics
5353

5454
## @param raw_metric_prefix - string - optional
5555
## A prefix that is removed from all exposed metric names, if present.

karpenter/tests/common.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
HERE = get_here()
99
HOST = get_docker_hostname()
10-
PORT = 8000
10+
PORT = 8080
1111

1212

1313
def get_fixture_path(filename):

karpenter/tests/docker/Caddyfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
:8000 {
1+
:8080 {
22
root * /metrics
33
file_server
44
}

karpenter/tests/docker/docker-compose.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ services:
55
image: caddy:2.7
66
container_name: caddy
77
ports:
8-
- "8000:8000"
8+
- "8080:8080"
99
volumes:
1010
- ./Caddyfile:/etc/caddy/Caddyfile
1111
- ../fixtures/karpenter_metrics.txt:/metrics/metrics

0 commit comments

Comments
 (0)