Fix false positives on constructor (#1729)

Author: norhh

mythril/analysis/module/modules/external_calls.py

@@ -71,6 +71,9 @@ def _analyze_state(self, state: GlobalState):
         :param state:
         :return:
         """
+        if state.environment.active_function_name == "constructor":
+            return []
+
         gas = state.mstate.stack[-1]
         to = state.mstate.stack[-2]
 

mythril/analysis/module/modules/state_change_external_calls.py

@@ -42,6 +42,7 @@ def __copy__(self):
     def get_issue(
         self, global_state: GlobalState, detector: DetectionModule
     ) -> Optional[PotentialIssue]:
+
         if not self.state_change_states:
             return None
         constraints = Constraints()
@@ -146,6 +147,9 @@ def _add_external_call(global_state: GlobalState) -> None:
 
     def _analyze_state(self, global_state: GlobalState) -> List[PotentialIssue]:
 
+        if global_state.environment.active_function_name == "constructor":
+            return []
+
         annotations = cast(
             List[StateChangeCallsAnnotation],
             list(global_state.get_annotations(StateChangeCallsAnnotation)),

mythril/analysis/report.py

@@ -146,11 +146,7 @@ def add_code_info(self, contract):
         """
         if self.address and isinstance(contract, SolidityContract):
             is_constructor = False
-            if (
-                contract.creation_code
-                in self.transaction_sequence["steps"][-1]["input"]
-                and self.function == "constructor"
-            ):
+            if self.function == "constructor":
                 is_constructor = True
 
             if self.source_location: