Add tests for generated hd priv keys

Author: mpolci

test/fixtures/keystore.json

@@ -149,5 +149,70 @@
       "ent1" : "c",
       "targetHash" : "ba7816bf8f01cfea414140de5dae2223b00361a396177a9cb410ff61f20015ad"
     }
+  ],
+  "mnemonicSeedTests": [
+    {
+      "password" : "password",
+      "salt": "lightwalletSalt",
+      "pwDerivedKey" : [12, 37, 184, 176, 141, 255, 15, 70, 189, 195, 206, 218, 109, 172, 141, 233, 117, 114, 2, 10, 156, 57, 255, 102, 37, 66, 2, 177, 82, 70, 1, 246],
+      "mnSeed": "jelly better achieve collect unaware mountain thought cargo oxygen act hood bridge",
+      "hdRootPriv": "xprv9s21ZrQH143K3vCy7FkijuhZgUbbTSGwrWmvwyLsW7bHDwtE3x5fXLfMTX4N3sHGfCRwRr9n7R5fGg5y6sRhbQN7J58mu1gbMputHnrZYAw"
+    },
+    {
+      "password" : "asdflknwqeroilasdflkjnzvmnwmet",
+      "salt": "lightwalletSalt",
+      "pwDerivedKey" : [24,100,147,66,23,117,206,186,27,54,254,137,187,174,103,5,38,18,139,128,139,74,217,188,166,34,0,30,54,133,158,208],
+      "mnSeed": "afford alter spike radar gate glance object seek swamp infant panel yellow",
+      "hdRootPriv": "xprv9s21ZrQH143K4F3jaSGsPkj54F6VXF3DZxjb69DH4AVmoYanpgwLA8RqQMXV1nbXyQrsXzwiY15sxt3sgh4rD61S6aXd5DmVSvbonWem6HR"
+    },
+    {
+      "password" : "!@&#*#()",
+      "salt": "lightwalletSalt",
+      "pwDerivedKey" : [51,238,218,224,61,216,29,19,249,245,254,125,54,245,160,253,1,73,137,234,137,138,109,226,61,11,128,41,76,115,80,43],
+      "mnSeed": "turtle front uncle idea crush write shrug there lottery flower risk shell",
+      "hdRootPriv": "xprv9s21ZrQH143K3ENdSTFWNa61Dpo7TyVwXdNGnr9LX4UGqEJgCxGhnDmAeVZTPTddYgpDPTQqyruHCyuRHx5yAbnLSzce4GhGHWmXLyi3ujA"
+    },
+    {
+      "password" : "PassHello",
+      "salt": "lightwalletSalt",
+      "pwDerivedKey" : [113,91,117,133,102,129,128,16,251,116,91,122,215,255,183,202,72,108,222,129,238,46,143,236,132,13,127,227,110,202,254,112],
+      "mnSeed": "board flee heavy tunnel powder denial science ski answer betray cargo cat",
+      "hdRootPriv": "xprv9s21ZrQH143K33giBRhHYG2HGme23pHx8zPWqM7H6jVuj5Uz47GefcuhFf4U8AtCRQVpGZRrSfgz8A4v7v9rFUG1eyYvL9Z1GhDEjCRVWdd"
+    },
+    {
+      "password" : "password",
+      "salt": "strangeSalt",
+      "pwDerivedKey": [205, 127, 41, 55, 40, 243, 95, 138, 187, 239, 244, 242, 33, 239, 174, 4, 146, 184, 75, 185, 221, 160, 223, 207, 124, 49, 16, 208, 237, 141, 15, 120],
+      "mnSeed": "そいとげる　かぶか　しちりん　かわく　がいらい　けしごむ　ときおり　くさい　そっこう　さめる　たいまつばな　うすめる",
+      "hdRootPriv": "xprv9s21ZrQH143K4ZC7EcgBoLbGp4BRVNNGhQZ1KCtMxYNkKXELKKe97BkPu9xj2M7NhksgyApceqk8wJANuNwhHR4DzsakecLhR28aCwk5XHd"
+    },
+    {
+      "password" : "password",
+      "salt": "strangeSalt",
+      "pwDerivedKey": [205, 127, 41, 55, 40, 243, 95, 138, 187, 239, 244, 242, 33, 239, 174, 4, 146, 184, 75, 185, 221, 160, 223, 207, 124, 49, 16, 208, 237, 141, 15, 120],
+      "mnSeed": "conocer cero abeja falso crónica norma clínica vivaz pañuelo tubería innato género",
+      "hdRootPriv": "xprv9s21ZrQH143K2ZciTt8VLGEYMuqt9jV6LyHWES2TipbgiRjEGE547Y3SfJZcDphfT2ysr48e7kzScN2xJJ4r8yR2RnFLurvDo7WA2xRqfnu"
+    },
+    {
+      "password" : "password",
+      "salt": "strangeSalt",
+      "pwDerivedKey": [205, 127, 41, 55, 40, 243, 95, 138, 187, 239, 244, 242, 33, 239, 174, 4, 146, 184, 75, 185, 221, 160, 223, 207, 124, 49, 16, 208, 237, 141, 15, 120],
+      "mnSeed": "标 叫 是 控 专 网 约 堵 怪 胺 居 医",
+      "hdRootPriv": "xprv9s21ZrQH143K2uixweugxzUnaxgxrWyy6oPuf3JAvFNLQTYc5a7PJRxK99bzomR2RPLve6z68zVdHTsbheYYcUBsbFeQiFt5o8Yk3XqnsCu"
+    },
+    {
+      "password" : "password",
+      "salt": "strangeSalt",
+      "pwDerivedKey": [205, 127, 41, 55, 40, 243, 95, 138, 187, 239, 244, 242, 33, 239, 174, 4, 146, 184, 75, 185, 221, 160, 223, 207, 124, 49, 16, 208, 237, 141, 15, 120],
+      "mnSeed": "rouge racine arriver sucre chute phrase moqueur désigner arriver décembre nuancer chien",
+      "hdRootPriv": "xprv9s21ZrQH143K2Mg2MDBrYxpmZ7MUarcQnF9G1jzKU4MSZoNfjepSwZTZF83JZB42pdwydCtgLp2PrKbPLXSSEQXwaeSitQ7qzSNzVNUPDY8"
+    },
+    {
+      "password" : "password",
+      "salt": "strangeSalt",
+      "pwDerivedKey": [205, 127, 41, 55, 40, 243, 95, 138, 187, 239, 244, 242, 33, 239, 174, 4, 146, 184, 75, 185, 221, 160, 223, 207, 124, 49, 16, 208, 237, 141, 15, 120],
+      "mnSeed": "smeraldo scodella arso tecnico continuo rischio peso eletto arso domato prefisso comodo",
+      "hdRootPriv": "xprv9s21ZrQH143K4AucDHZwwJKWYXT3X5FNAK4cfWGHR8dMrdvuJk2jv5SoiBD21hPtB4VTNLeWh7sVyaiVHjV5oEvzQuDyyyviZQPxjRxoaUd"
+    }
   ]
 }

test/keystore.js

@@ -17,23 +17,6 @@ var Transaction = require('ethereumjs-tx');
 describe("Keystore", function() {
 
   describe("createVault constructor", function() {
-    it('accepts a variety of options', function(done) {
-      var fixture = fixtures.valid[0];
-
-      keyStore.createVault({
-        password: fixture.password,
-        seedPhrase: fixture.mnSeed,
-        salt: fixture.salt,
-      }, function(err, ks) {
-        expect(ks.encSeed).to.not.equal(undefined);
-        var decryptedPaddedSeed = keyStore._decryptString(ks.encSeed, Uint8Array.from(fixtures.valid[0].pwDerivedKey));
-        // Check padding
-        expect(decryptedPaddedSeed.length).to.equal(120);
-        expect(decryptedPaddedSeed.trim()).to.equal(fixtures.valid[0].mnSeed);
-        done();
-      });
-    });
-
     Object.keys(Mnemonic.Words).forEach(function (lang) {
       it('should generete random seed of language ' + lang, function (done) {
         var fixture = fixtures.valid[0];
@@ -45,8 +28,7 @@ describe("Keystore", function() {
         }, function (err, ks) {
           if (err) return done(err)
           expect(ks.encSeed).to.not.equal(undefined);
-          var decryptedPaddedSeed = keyStore._decryptString(ks.encSeed, Uint8Array.from(fixtures.valid[0].pwDerivedKey));
-          // Check padding
+          var decryptedPaddedSeed = keyStore._decryptString(ks.encSeed, Uint8Array.from(fixture.pwDerivedKey));
           var words = decryptedPaddedSeed.trim().split(/\s/);
           words.forEach(function (w) {
             expect(Mnemonic.Words[lang].indexOf(w)).to.not.equal(-1, 'word ' + w + ' is not in dictionary');
@@ -56,6 +38,40 @@ describe("Keystore", function() {
       });
     })
 
+    fixtures.mnemonicSeedTests.forEach(function (fixture) {
+      it('should store mnemonic seed "' + fixture.mnSeed + '"', function (done) {
+        keyStore.createVault({
+          password: fixture.password,
+          seedPhrase: fixture.mnSeed,
+          salt: fixture.salt,
+        }, function(err, ks) {
+          if (err) return done(err)
+          expect(ks.encSeed).to.not.equal(undefined);
+          var decryptedPaddedSeed = keyStore._decryptString(ks.encSeed, Uint8Array.from(fixture.pwDerivedKey));
+          // Check padding
+          expect(decryptedPaddedSeed.length).to.equal(120);
+          expect(decryptedPaddedSeed.trim()).to.equal(fixture.mnSeed);
+          done();
+        });
+      })
+    });
+
+    fixtures.mnemonicSeedTests.forEach(function (fixture) {
+      it('should generate HD root key for seed "' + fixture.mnSeed + '"', function (done) {
+        keyStore.createVault({
+          password: fixture.password,
+          seedPhrase: fixture.mnSeed,
+          salt: fixture.salt,
+        }, function (err, ks) {
+          if (err) return done(err)
+          expect(ks.encSeed).to.not.equal(undefined);
+          var decryptedHdRootPriv = keyStore._decryptString(ks.encHdRootPriv, Uint8Array.from(fixture.pwDerivedKey));
+          expect(decryptedHdRootPriv.trim()).to.equal(fixture.hdRootPriv);
+          done();
+        });
+      });
+    });
+
     it('generates a random salt for key generation', function(done) {
       this.timeout(10000);
       var fixture = fixtures.valid[0];