feat(twistededwards): add fixed-base base scalar mul for eddsa#839
Open
peter941221 wants to merge 2 commits into
Open
feat(twistededwards): add fixed-base base scalar mul for eddsa#839peter941221 wants to merge 2 commits into
peter941221 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 4ea721c. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
GenerateKey,Sign, and[S]BaseinsideVerifywithout changing generic variable-base semanticsValidation
Ref #775.
Note
Medium Risk
Touches core elliptic-curve scalar multiplication and EdDSA keygen/sign/verify paths across multiple curves; any bug could break signature validity or introduce subtle side-channel/constant-time regressions despite added differential tests.
Overview
Adds a generator-driven, constant-time fixed-base scalar multiplication path for twisted Edwards curves via
PointAffine.ScalarMultiplicationBase, using a lazily-initialized 4-bit window table and constant-time point selection.Updates EdDSA implementations across supported curves to use the new fixed-base routine for public-key derivation in
GenerateKey, computingR = [r]BaseinSign, and the[S]Baseterm inVerify.Expands test coverage with generic-reference regressions and fixed-base vs generic differential checks, and adds benchmarks for keygen/sign plus generic-vs-fixed base multiplication performance comparisons.
Reviewed by Cursor Bugbot for commit 6a3b102. Bugbot is set up for automated code reviews on this repo. Configure here.