Skip to content

Replace peersConnected() method for testing purposes with an API call in the  #288

@Filter94

Description

@Filter94

Description

MaruApp.awaitTillMaruHasPeers relies on the peersConnected method to get the number of peers connected to an instance. However we also have the GET /eth/v1/node/peers REST endpoint that should return all the peers connected to it. Instead of exposing the internal peersConnected, we could use the API call

Motivation

This would shrink the MaruApp's API and it would indirectly cover that endpoint with some tests

Tasks

  • Remove the peersConnected
  • Change MaruApp.awaitTillMaruHasPeers to use the Beacon REST API to check the number of connected peers

Acceptance criteria

  • MaruApp doesn't have peersConnected method, MaruApp.awaitTillMaruHasPeers still check the number of node's peers

Risks

  • None

Remember to

  • Add the documentation label in case there is an impact on the documentation
  • Add priority and team labels
  • Add Task for updating the Runbook or adding/updating existing metrics and alerts.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions