Fixes for backwards compatibility

Author: azvoleff

gefapi/routes/api/v1/gef_api_router.py

@@ -266,6 +266,7 @@ def get_executions():
     end_date_lte = request.args.get("end_date_lte", None)
     if end_date_lte:
         end_date_lte = dateutil.parser.parse(end_date_lte)
+
     sort = request.args.get("sort", None)
     include = request.args.get("include")
     include = include.split(",") if include else []
@@ -351,7 +352,7 @@ def update_execution(execution):
 @endpoints.route("/execution/<execution>/log", strict_slashes=False, methods=["GET"])
 def get_execution_logs(execution):
     """Get the exectuion logs"""
-    logger.info("[ROUTER]: Getting exectuion logs of execution %s " % (execution))
+    logger.info("[ROUTER]: Getting execution logs of execution %s " % (execution))
     try:
         start = request.args.get("start", None)
         if start:

gefapi/services/execution_service.py

@@ -59,9 +59,12 @@ def get_executions(
     ):
         logger.info("[SERVICE]: Getting executions")
         logger.info("[DB]: QUERY")
-        if not updated_at:
-            updated_at = datetime.datetime(2000, 12, 1)
         query = None
+        if page < 1:
+            raise Exception("Page must be greater than 0")
+        if per_page < 1:
+            raise Exception("Per page must be greater than 0")
+
         # Admin
         if user.role == "ADMIN":
             # Target User
@@ -81,8 +84,6 @@ def get_executions(
         else:
             query = db.session.query(Execution).filter(Execution.user_id == user.id)
 
-        query = query.filter(Execution.end_date > updated_at)
-
         if status:
             query = query.filter(Execution.status == status)
         if start_date_gte:
@@ -93,6 +94,10 @@ def get_executions(
             query = query.filter(Execution.end_date >= end_date_gte)
         if end_date_lte:
             query = query.filter(Execution.end_date <= end_date_lte)
+        elif updated_at:
+            # For backwards compatibility, if no end_date_lte is provided,
+            # filter by updated_at
+            query = query.filter(Execution.end_date >= updated_at)
 
         if sort:
             sort_field = sort[1:] if sort.startswith("-") else sort
@@ -102,6 +107,7 @@ def get_executions(
                     getattr(getattr(Execution, sort_field), sort_direction)()
                 )
         else:
+            # Default to sorting by end_date for backwards compatibility
             query = query.order_by(Execution.end_date.desc())
 
         total = query.count()