Fix test failures in password reset token tests

- Fixed Error class to properly pass message to Exception base class for pytest matching
- Fixed timezone handling in user_service.py to use utcnow() instead of now(UTC)
- Updated all test datetime instances to use timezone-naive datetimes (utcnow())
- Ensures consistency with existing database schema that doesn't support timezone-aware datetimes

Co-authored-by: azvoleff <107753+azvoleff@users.noreply.github.com>

Author: Copilot

gefapi/errors.py

@@ -4,6 +4,7 @@
 class Error(Exception):
     def __init__(self, message):
         self.message = message
+        super().__init__(message)
 
     @property
     def serialize(self):

gefapi/services/user_service.py

@@ -756,7 +756,7 @@ def reset_password_with_token(token_string, new_password):
             # Mark user as email verified - they proved email access by using the token
             if not user.email_verified:
                 user.email_verified = True
-                user.email_verified_at = datetime.datetime.now(datetime.UTC)
+                user.email_verified_at = datetime.datetime.utcnow()
                 logger.info(
                     f"[SERVICE]: Email verified for {user.email} via password reset"
                 )

tests/test_password_reset_token.py

@@ -60,10 +60,8 @@ def test_reset_password_with_token_verifies_unverified_user(self, app):
             assert updated_user.email_verified is True
             assert updated_user.email_verified_at is not None
             # Verify the timestamp is recent (within last minute)
-            now = datetime.datetime.now(datetime.UTC)
-            time_diff = now - updated_user.email_verified_at.replace(
-                tzinfo=datetime.UTC
-            )
+            now = datetime.datetime.utcnow()
+            time_diff = now - updated_user.email_verified_at
             assert time_diff.total_seconds() < 60
 
     def test_reset_password_with_token_preserves_already_verified_user(self, app):
@@ -78,7 +76,7 @@ def test_reset_password_with_token_preserves_already_verified_user(self, app):
                 institution="Test Institution",
             )
             original_verification_time = datetime.datetime(
-                2024, 1, 1, 12, 0, 0, tzinfo=datetime.UTC
+                2024, 1, 1, 12, 0, 0
             )
             user.email_verified = True
             user.email_verified_at = original_verification_time
@@ -103,7 +101,7 @@ def test_reset_password_with_token_preserves_already_verified_user(self, app):
             assert updated_user.email_verified is True
             # Original verification time should be preserved (not updated)
             assert (
-                updated_user.email_verified_at.replace(tzinfo=datetime.UTC)
+                updated_user.email_verified_at
                 == original_verification_time
             )
 
@@ -136,9 +134,7 @@ def test_reset_password_with_expired_token_fails(self, app):
             # Create an expired token
             reset_token = PasswordResetToken(user_id=user.id)
             # Set expiry to the past
-            reset_token.expires_at = datetime.datetime.now(
-                datetime.UTC
-            ) - datetime.timedelta(hours=2)
+            reset_token.expires_at = datetime.datetime.utcnow() - datetime.timedelta(hours=2)
             db.session.add(reset_token)
             db.session.commit()
 
@@ -165,7 +161,7 @@ def test_reset_password_with_used_token_fails(self, app):
 
             # Create a token and mark it as used
             reset_token = PasswordResetToken(user_id=user.id)
-            reset_token.used_at = datetime.datetime.now(datetime.UTC)
+            reset_token.used_at = datetime.datetime.utcnow()
             db.session.add(reset_token)
             db.session.commit()