fix(dapp): curate outcome templates to registry and public goods

Author: Shadow-MMN

dapp/src/components/page/proposal/OutcomeInput.tsx

@@ -175,6 +175,14 @@ const OutcomeInput = ({
                 if (onModeChange) onModeChange("xdr");
                 setXdr(template.xdr);
                 if (onXdrChange) onXdrChange(template.xdr);
+              } else {
+                // Description-only templates represent outcomes with no
+                // execution. Clear any previous execution mode/data so a
+                // template cannot retain an older contract call or XDR.
+                setMode("none");
+                if (onModeChange) onModeChange("none");
+                setContractOutcome(null);
+                setXdr(null);
               }
             }}
           />

dapp/src/components/page/proposal/OutcomeTemplateSelector.tsx

@@ -23,6 +23,8 @@ export default function OutcomeTemplateSelector({
 
   const templates = getOutcomeTemplatesByType(outcomeType);
 
+  if (templates.length === 0) return null;
+
   const handleTemplateClick = useCallback(
     (template: OutcomeTemplate) => {
       onTemplateSelect(template);

dapp/src/constants/outcomeTemplates.ts

@@ -10,8 +10,9 @@
  *
  * Selecting a template pre-fills everything a user could otherwise fill out:
  * the description, and optionally the XDR transaction and/or the contract
- * call (address / function / arguments). Project-specific values (contract
- * addresses, amounts) are left as placeholders for the author to complete.
+ * call (address / function / arguments). The catalog intentionally stays
+ * small and follows the concrete registry and public-goods proposals used by
+ * Tansu.
  */
 
 export type OutcomeType = "approved" | "rejected" | "cancelled";
@@ -40,147 +41,56 @@ export interface OutcomeTemplate {
 export const OUTCOME_TEMPLATES: OutcomeTemplate[] = [
   // ---------------------------------------------------------------- Approved
   {
-    id: "approve-code-implementation",
-    name: "Execute Code Implementation",
+    id: "interact-stellar-registry",
+    name: "Interact with the Stellar Registry",
     description:
-      "For approved code proposals: merge the commit and record it on-chain",
+      "Publish an approved contract hash to the main/root Stellar Registry",
     outcomeType: "approved",
-    content: `# Approved: Code Implementation
+    content: `# Approved: Interact with the Stellar Registry
 
-The proposal was approved by the community. The proposed code changes will be merged and the commit hash will be recorded on-chain as the new repository revision.
+The proposal was approved by the community. The approved WASM hash will be published to the main/root Stellar Registry.
 
 ## Actions to Execute
-- [ ] Merge the approved commit [commit hash]
-- [ ] Record the commit hash on-chain
-- [ ] Publish the updated revision to the project repository
+- [ ] Resolve the approved contract through the Stellar Registry
+- [ ] Call \`publish_hash\` with the contract name, admin account, WASM hash, and version
+- [ ] Verify the published contract metadata on the registry
 
 ## Technical Details
-[Describe the XDR transaction or contract call that executes this outcome.]`,
+- Contract name: \`registry-tansu-manager\`
+- Admin account: \`GAMPJROHOAW662FINQ4XQOY2ULX5IEGYXCI4SMZYE75EHQBR6PSTJG3M\`
+- WASM hash: \`f13e2e9d329a1b5e72eed4c3203f98c36d513e9915de2482c229fbe4367e6591\`
+- Version: \`0.1.0\``,
     contract: {
       address: "",
-      execute_fn: "record_commit",
-      args: [""],
+      execute_fn: "publish_hash",
+      args: [
+        "registry-tansu-manager",
+        "GAMPJROHOAW662FINQ4XQOY2ULX5IEGYXCI4SMZYE75EHQBR6PSTJG3M",
+        "f13e2e9d329a1b5e72eed4c3203f98c36d513e9915de2482c229fbe4367e6591",
+        "0.1.0",
+      ],
     },
   },
   {
-    id: "approve-governance-update",
-    name: "Apply Governance Update",
+    id: "public-goods-award",
+    name: "Award / Public Goods Grant",
     description:
-      "For approved governance proposals: apply the new rule on-chain",
+      "Fund a public-goods maintenance proposal and report the payment",
     outcomeType: "approved",
-    content: `# Approved: Governance Update
+    content: `# Approved: Public Goods Award
 
-The proposal was approved. The governance rule change will now be applied on-chain and will take effect for future proposals and votes.
+The proposal was approved by the community. The requested budget of \`20,000 XLM\` will be awarded to the public-goods project for the approved maintenance work.
 
-## Actions to Execute
-- [ ] Update the governance parameter(s) described in the proposal
-- [ ] Confirm the new rules in the project configuration
-- [ ] Notify the community of the updated voting parameters`,
-    contract: {
-      address: "",
-      execute_fn: "update_config",
-      args: [""],
-    },
-  },
-  {
-    id: "approve-award-disbursement",
-    name: "Disburse Award",
-    description:
-      "For approved award/budget proposals: execute the transfer on-chain",
-    outcomeType: "approved",
-    content: `# Approved: Award Disbursement
-
-The proposal was approved. The requested budget will be disbursed to the beneficiary and the transfer will be executed on-chain.
-
-## Actions to Execute
-- [ ] Transfer [amount] XLM to [beneficiary address]
-- [ ] Record the disbursement transaction hash
-- [ ] Publish the transfer proof and a short spending report`,
-    contract: {
-      address: "",
-      execute_fn: "transfer",
-      args: ["", 0],
-    },
-  },
-  {
-    id: "approve-membership-update",
-    name: "Apply Membership Update",
-    description:
-      "For approved membership proposals: apply the maintainer/role change",
-    outcomeType: "approved",
-    content: `# Approved: Membership Update
-
-The proposal was approved. The membership change will be applied to the project's maintainer list and role configuration.
-
-## Actions to Execute
-- [ ] Add/remove the maintainer at address [address]
-- [ ] Update role permissions and voting weight
-- [ ] Confirm the new membership configuration on-chain`,
-    contract: {
-      address: "",
-      execute_fn: "add_maintainer",
-      args: [""],
-    },
-  },
-
-  // ---------------------------------------------------------------- Rejected
-  {
-    id: "reject-no-action",
-    name: "No Action Taken",
-    description:
-      "Generic template for rejected proposals that require no execution",
-    outcomeType: "rejected",
-    content: `# Rejected: No Action Taken
-
-The proposal was rejected by the community. No code changes will be merged and no on-chain action will be executed as a result of this proposal.
-
-## Consequences
-- The current repository revision remains unchanged
-- No payments, rewards, or membership changes will be applied`,
-  },
-  {
-    id: "reject-code-change",
-    name: "Reject Code Change",
-    description:
-      "For rejected code proposals: the commit is not merged or recorded",
-    outcomeType: "rejected",
-    content: `# Rejected: Code Change Not Merged
-
-The proposal was rejected. The proposed code changes will NOT be merged and the commit [commit hash] will not be recorded on-chain.
-
-## Consequences
-- The repository stays on revision [current revision]
-- The author may revise the change and submit a new proposal`,
-  },
-
-  // --------------------------------------------------------------- Cancelled
-  {
-    id: "cancelled-no-action",
-    name: "No Action Taken",
-    description:
-      "Generic template for cancelled proposals that require no execution",
-    outcomeType: "cancelled",
-    content: `# Cancelled: No Action Taken
-
-The proposal was cancelled before the voting period concluded. No actions will be executed and no state changes will be applied.
-
-## Consequences
-- The current repository revision remains unchanged
-- No payments, rewards, or membership changes were applied`,
-  },
-  {
-    id: "cancelled-resubmission",
-    name: "Ready for Resubmission",
-    description:
-      "For cancelled proposals that can be revised and resubmitted later",
-    outcomeType: "cancelled",
-    content: `# Cancelled: Ready for Resubmission
-
-The proposal was cancelled by the proposer or the maintainers. The subject may be revised and resubmitted as a new proposal in the future.
+## Award Details
+- Amount: \`20,000 XLM\`
+- Beneficiary: [beneficiary address or project treasury]
+- Payment: [describe the payment schedule or transaction]
 
-## Notes
-- No on-chain action was executed
-- A new proposal should reference this cancellation for context`,
+## Payment and Reporting
+- [ ] Confirm the beneficiary and payment destination
+- [ ] Execute the approved payment
+- [ ] Record and publish the payment transaction hash
+- [ ] Publish progress and completion reports for the funded deliverables`,
   },
 ];
 

dapp/tests/unit/constants/outcomeTemplates.test.ts

@@ -10,13 +10,17 @@ import {
 const OUTCOME_TYPES: OutcomeType[] = ["approved", "rejected", "cancelled"];
 
 describe("OUTCOME_TEMPLATES", () => {
-  it("covers all 3 outcome types", () => {
-    for (const outcomeType of OUTCOME_TYPES) {
-      const templates = OUTCOME_TEMPLATES.filter(
-        (template) => template.outcomeType === outcomeType,
-      );
-      expect(templates.length).toBeGreaterThan(0);
-    }
+  it("contains only the curated registry and public-goods templates", () => {
+    expect(OUTCOME_TEMPLATES).toHaveLength(2);
+    expect(OUTCOME_TEMPLATES.map((template) => template.id)).toEqual([
+      "interact-stellar-registry",
+      "public-goods-award",
+    ]);
+    expect(
+      OUTCOME_TEMPLATES.every(
+        (template) => template.outcomeType === "approved",
+      ),
+    ).toBe(true);
   });
 
   it("has unique ids", () => {
@@ -43,31 +47,28 @@ describe("OUTCOME_TEMPLATES", () => {
     }
   });
 
-  it("pre-fills contract calls only on templates that execute an action", () => {
-    // Approved templates execute real actions, so they should come with a
-    // contract-call pre-fill (function + args) while the no-action rejected /
-    // cancelled templates stay description-only.
-    const approved = getOutcomeTemplatesByType("approved");
-    for (const template of approved) {
-      expect(template.contract).toBeDefined();
-      expect(template.contract!.execute_fn.trim().length).toBeGreaterThan(0);
-      expect(template.contract!.address).toBe(""); // filled by the author
-    }
-
-    for (const type of ["rejected", "cancelled"] as const) {
-      for (const template of getOutcomeTemplatesByType(type)) {
-        expect(template.contract).toBeUndefined();
-        expect(template.xdr).toBeUndefined();
-      }
-    }
+  it("pre-fills the registry contract call and leaves its address for resolution", () => {
+    const registry = getOutcomeTemplateById("interact-stellar-registry")!;
+    expect(registry.contract).toEqual({
+      address: "",
+      execute_fn: "publish_hash",
+      args: [
+        "registry-tansu-manager",
+        "GAMPJROHOAW662FINQ4XQOY2ULX5IEGYXCI4SMZYE75EHQBR6PSTJG3M",
+        "f13e2e9d329a1b5e72eed4c3203f98c36d513e9915de2482c229fbe4367e6591",
+        "0.1.0",
+      ],
+    });
+    expect(
+      getOutcomeTemplateById("public-goods-award")?.contract,
+    ).toBeUndefined();
   });
 });
 
 describe("getOutcomeTemplatesByType", () => {
   it("returns only templates matching the requested outcome type", () => {
     for (const outcomeType of OUTCOME_TYPES) {
       const templates = getOutcomeTemplatesByType(outcomeType);
-      expect(templates.length).toBeGreaterThan(0);
       for (const template of templates) {
         expect(template.outcomeType).toBe(outcomeType);
       }
@@ -102,14 +103,16 @@ describe("getOutcomeTemplateFills", () => {
   });
 
   it("reports contract-call pre-fill when the template has one", () => {
-    const approved = getOutcomeTemplatesByType("approved");
-    for (const template of approved) {
-      expect(getOutcomeTemplateFills(template)).toContain("contract call");
-    }
+    expect(
+      getOutcomeTemplateFills(
+        getOutcomeTemplateById("interact-stellar-registry")!,
+      ),
+    ).toContain("contract call");
   });
 
   it("reports only the description for no-action templates", () => {
-    const rejected = getOutcomeTemplatesByType("rejected");
-    expect(getOutcomeTemplateFills(rejected[0]!)).toEqual(["description"]);
+    expect(
+      getOutcomeTemplateFills(getOutcomeTemplateById("public-goods-award")!),
+    ).toEqual(["description"]);
   });
 });