Skip to content

Commit d644ebb

Browse files
jeremymanningclaude
andcommitted
Fix: format the file my last edit left unformatted; align the two black scopes
The AWS cleanup test assertions were widened by hand and not re-run through black. Quick Checks caught it. fast_ci checked black on clustrix/ tests/ while tests.yml checked clustrix/ tests/ scripts/, so a file under scripts/ could pass one gate and fail the other. Same scope now. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012gTBDPK16HUZ3kHQ2QyjuU
1 parent 5952600 commit d644ebb

2 files changed

Lines changed: 15 additions & 5 deletions

File tree

.github/workflows/fast_ci.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,9 @@ jobs:
4747
pip install -e ".[dev]"
4848
4949
- name: Format check with Black
50-
run: black --check clustrix/ tests/
50+
# Same scope as tests.yml's black step. They covered different
51+
# directories, so a file could pass one gate and fail the other.
52+
run: black --check clustrix/ tests/ scripts/
5153

5254
- name: Lint with Flake8
5355
run: flake8 clustrix/ --count --select=E9,F63,F7,F82 --show-source --statistics

tests/unit/test_aws_cleanup_scripts.py

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,9 @@ def test_cleanup_dry_run_without_credentials_errors_clearly(self):
135135
# AWS SDK, so the SDK message is the one it hits; a developer machine
136136
# with boto3 installed hits the credential one.
137137
assert "credential" in output or "aws sdk" in output, output
138-
assert "pip install boto3" in output or "aws_access_key_id" in output.lower(), output
138+
assert (
139+
"pip install boto3" in output or "aws_access_key_id" in output.lower()
140+
), output
139141

140142
def test_cleanup_execute_without_credentials_also_errors_clearly(self):
141143
# --execute must not bypass the credential check either.
@@ -167,7 +169,9 @@ def test_cleanup_execute_without_credentials_also_errors_clearly(self):
167169
# AWS SDK, so the SDK message is the one it hits; a developer machine
168170
# with boto3 installed hits the credential one.
169171
assert "credential" in output or "aws sdk" in output, output
170-
assert "pip install boto3" in output or "aws_access_key_id" in output.lower(), output
172+
assert (
173+
"pip install boto3" in output or "aws_access_key_id" in output.lower()
174+
), output
171175

172176
def test_destroy_dry_run_without_credentials_errors_clearly(self):
173177
env, tmp_home = _clean_env_without_aws_credentials()
@@ -201,7 +205,9 @@ def test_destroy_dry_run_without_credentials_errors_clearly(self):
201205
# AWS SDK, so the SDK message is the one it hits; a developer machine
202206
# with boto3 installed hits the credential one.
203207
assert "credential" in output or "aws sdk" in output, output
204-
assert "pip install boto3" in output or "aws_access_key_id" in output.lower(), output
208+
assert (
209+
"pip install boto3" in output or "aws_access_key_id" in output.lower()
210+
), output
205211

206212
def test_destroy_execute_without_credentials_also_errors_clearly(self):
207213
env, tmp_home = _clean_env_without_aws_credentials()
@@ -233,7 +239,9 @@ def test_destroy_execute_without_credentials_also_errors_clearly(self):
233239
# AWS SDK, so the SDK message is the one it hits; a developer machine
234240
# with boto3 installed hits the credential one.
235241
assert "credential" in output or "aws sdk" in output, output
236-
assert "pip install boto3" in output or "aws_access_key_id" in output.lower(), output
242+
assert (
243+
"pip install boto3" in output or "aws_access_key_id" in output.lower()
244+
), output
237245

238246

239247
class TestArgParsingRoundTrip:

0 commit comments

Comments
 (0)