Fix env ordering to allow overriding via agentconfig

Author: gamingrobot

manifests/install/testing/overlays/deployment.yaml

@@ -16,3 +16,5 @@ spec:
               value: "true"
             - name: "CONTRAST_LOG_LEVEL"
               value: "TRACE"
+            - name: "CONTRAST_ENABLE_AGENT_STDOUT"
+              value: "true"

src/Contrast.K8s.AgentOperator/Core/Reactions/Injecting/Patching/PodPatcher.cs

@@ -298,11 +298,6 @@ private IEnumerable<V1EnvVar> GenerateEnvVars(PatchingContext context, V1Pod pod
         yield return new V1EnvVar("CONTRAST_MOUNT_AGENT_PATH", agentMountPath);
         yield return new V1EnvVar("CONTRAST_MOUNT_WRITABLE_PATH", writableMountPath);
 
-        if (_operatorOptions.EnableAgentStdout)
-        {
-            yield return new V1EnvVar("CONTRAST__AGENT__LOGGER__STDOUT", "true");
-        }
-
         if (connection.TeamServerUri != null)
         {
             yield return new V1EnvVar("CONTRAST__API__URL", connection.TeamServerUri);
@@ -387,7 +382,12 @@ private IEnumerable<V1EnvVar> GenerateEnvVars(PatchingContext context, V1Pod pod
             }
         }
 
-        // Order does matter here, make sure these next two are after YamlKeys.
+        // Order does matter here, YamlKeys values take precedent.
+        if (_operatorOptions.EnableAgentStdout)
+        {
+            yield return new V1EnvVar("CONTRAST__AGENT__LOGGER__STDOUT", "true");
+        }
+
         if (configuration?.SuppressDefaultServerName != true
             && !string.IsNullOrWhiteSpace(workloadNamespace))
         {