Fix GetShortHash, old ShortHash handled length incorrectly so this matches the old functionality now

Author: gamingrobot

src/Contrast.K8s.AgentOperator/Core/HashHelper.cs

@@ -14,7 +14,7 @@ public static string GetShortHash(string text)
         using var sha256 = SHA256.Create();
         var bytes = Encoding.UTF8.GetBytes(text);
         var hash = sha256.ComputeHash(bytes);
-        return Convert.ToHexStringLower(hash, 0, 8);
+        return Convert.ToHexStringLower(hash, 0, 5);
     }
 
     public static string Sha256(string text)

src/Contrast.K8s.AgentOperator/Core/Reactions/Secrets/AgentConnectionVolumeSecretHandler.cs

@@ -147,9 +147,7 @@ private async Task<string> CreateDerivedSecretHash(ResourceIdentityPair<AgentCon
             }
         }
 
-        using var sha256 = SHA256.Create();
-        var bytes = sha256.ComputeHash(Encoding.ASCII.GetBytes(secretKeyHashes.ToString()));
-        return Convert.ToHexStringLower(bytes);
+        return HashHelper.Sha256(secretKeyHashes.ToString());
     }
 
     private async Task<byte[]?> CreateLiveConfig(ResourceIdentityPair<AgentConnectionResource> connectionResource)

tests/Contrast.K8s.AgentOperator.FunctionalTests/Scenarios/Injection/InitContainerOverrideTests.cs

@@ -37,7 +37,7 @@ public async Task When_any_overrides_are_applied_a_debugging_env_var_should_be_a
             var container = result.Spec.InitContainers.Single(x => x.Name == "contrast-init");
             var env = container.Env;
 
-            env.Should().ContainSingle(x => x.Name == "CONTRAST_DEBUGGING_SECURITY_CONTEXT_TAINTED").Which.Value.Should().Be("True");
+            env.Should().ContainSingle(x => x.Name == "CONTRAST_DEBUGGING_SECURITY_CONTEXT_TAINTED").Which.Value.Should().Be("true");
         }
     }