Skip to content

Commit e9bbb86

Browse files
committed
change getDisplayName to only displayed filename, to be both used in Runtime and editor
1 parent 6190428 commit e9bbb86

File tree

4 files changed

+13
-16
lines changed

4 files changed

+13
-16
lines changed

app/display/editor/src/main/java/org/csstudio/display/builder/editor/app/DisplayEditorInstance.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77
******************************************************************************/
88
package org.csstudio.display.builder.editor.app;
99

10-
import static org.csstudio.display.builder.model.properties.CommonWidgetProperties.propFile;
11-
1210
import java.io.File;
1311
import java.net.URI;
1412
import java.text.MessageFormat;
@@ -32,6 +30,7 @@
3230
import org.csstudio.display.builder.model.WidgetProperty;
3331
import org.csstudio.display.builder.model.WidgetPropertyListener;
3432
import org.csstudio.display.builder.model.persist.WidgetClassesService;
33+
import static org.csstudio.display.builder.model.properties.CommonWidgetProperties.propFile;
3534
import org.csstudio.display.builder.model.util.ModelThreadPool;
3635
import org.csstudio.display.builder.model.widgets.GroupWidget;
3736
import org.csstudio.display.builder.representation.javafx.FilenameSupport;
@@ -80,10 +79,10 @@ public class DisplayEditorInstance implements AppInstance
8079

8180
private final WidgetPropertyListener<String> model_name_listener = (property, old_value, new_value) ->
8281
{
83-
String userDataInputFile = property.getWidget().getUserData(DisplayModel.USER_DATA_INPUT_FILE);
82+
String fileName = property.getWidget().checkDisplayModel().getDisplayName();
8483

8584
String value = (property.getValue() == null || property.getValue().isEmpty())
86-
? userDataInputFile
85+
? fileName
8786
: property.getValue();
8887

8988
final String label = EditorUtil.isDisplayReadOnly(property.getWidget().checkDisplayModel())

app/display/model/src/main/java/org/csstudio/display/builder/model/DisplayModel.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,16 @@
77
*******************************************************************************/
88
package org.csstudio.display.builder.model;
99

10-
import static org.csstudio.display.builder.model.properties.CommonWidgetProperties.newBooleanPropertyDescriptor;
11-
import static org.csstudio.display.builder.model.properties.CommonWidgetProperties.newColorPropertyDescriptor;
12-
import static org.csstudio.display.builder.model.properties.CommonWidgetProperties.newIntegerPropertyDescriptor;
13-
import static org.csstudio.display.builder.model.properties.CommonWidgetProperties.propBackgroundColor;
14-
import static org.csstudio.display.builder.model.properties.CommonWidgetProperties.propMacros;
15-
1610
import java.util.List;
1711

1812
import org.csstudio.display.builder.model.persist.ModelReader;
1913
import org.csstudio.display.builder.model.persist.NamedWidgetColors;
2014
import org.csstudio.display.builder.model.persist.WidgetColorService;
15+
import static org.csstudio.display.builder.model.properties.CommonWidgetProperties.newBooleanPropertyDescriptor;
16+
import static org.csstudio.display.builder.model.properties.CommonWidgetProperties.newColorPropertyDescriptor;
17+
import static org.csstudio.display.builder.model.properties.CommonWidgetProperties.newIntegerPropertyDescriptor;
18+
import static org.csstudio.display.builder.model.properties.CommonWidgetProperties.propBackgroundColor;
19+
import static org.csstudio.display.builder.model.properties.CommonWidgetProperties.propMacros;
2120
import org.csstudio.display.builder.model.properties.WidgetColor;
2221
import org.csstudio.display.builder.model.widgets.EmbeddedDisplayWidget;
2322
import org.csstudio.display.builder.model.widgets.NavigationTabsWidget;
@@ -173,6 +172,8 @@ public String getDisplayName()
173172
name = getUserData(USER_DATA_INPUT_FILE);
174173
if (name == null)
175174
name = "<No name>";
175+
else
176+
name= new java.io.File(name).getName();;
176177
}
177178
return name;
178179
}

app/display/runtime/src/main/java/org/csstudio/display/builder/runtime/app/DisplayInfo.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77
*******************************************************************************/
88
package org.csstudio.display.builder.runtime.app;
99

10-
import static org.csstudio.display.builder.runtime.WidgetRuntime.logger;
11-
1210
import java.io.UnsupportedEncodingException;
1311
import java.net.URI;
1412
import java.net.URISyntaxException;
@@ -18,6 +16,7 @@
1816

1917
import org.csstudio.display.builder.model.DisplayModel;
2018
import org.csstudio.display.builder.model.macros.MacroHandler;
19+
import static org.csstudio.display.builder.runtime.WidgetRuntime.logger;
2120
import org.phoebus.framework.macros.Macros;
2221
import org.phoebus.framework.util.ResourceParser;
2322

app/display/runtime/src/main/java/org/csstudio/display/builder/runtime/app/DisplayRuntimeInstance.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,15 @@
77
******************************************************************************/
88
package org.csstudio.display.builder.runtime.app;
99

10-
import static org.csstudio.display.builder.runtime.WidgetRuntime.logger;
11-
12-
1310
import java.awt.geom.Rectangle2D;
1411
import java.util.ArrayList;
1512
import java.util.Objects;
1613
import java.util.Optional;
1714
import java.util.concurrent.Callable;
1815
import java.util.concurrent.Future;
16+
import java.util.concurrent.FutureTask;
1917
import java.util.concurrent.TimeUnit;
2018
import java.util.concurrent.TimeoutException;
21-
import java.util.concurrent.FutureTask;
2219
import java.util.logging.Level;
2320

2421
import org.csstudio.display.builder.model.DisplayModel;
@@ -30,6 +27,7 @@
3027
import org.csstudio.display.builder.representation.javafx.JFXRepresentation;
3128
import org.csstudio.display.builder.runtime.ActionUtil;
3229
import org.csstudio.display.builder.runtime.RuntimeUtil;
30+
import static org.csstudio.display.builder.runtime.WidgetRuntime.logger;
3331
import org.phoebus.framework.jobs.JobManager;
3432
import org.phoebus.framework.jobs.JobMonitor;
3533
import org.phoebus.framework.macros.Macros;

0 commit comments

Comments
 (0)