Merge pull request #1005 from Sibirius/feature/manage-gameobject-is-static

feat(manage_gameobject): add is_static parameter to modify action

Author: Scriptwonder

MCPForUnity/Editor/Tools/GameObjects/GameObjectModify.cs

@@ -151,6 +151,19 @@ internal static object Handle(JObject @params, JToken targetToken, string search
                 }
             }
 
+            bool? isStatic = @params["isStatic"]?.ToObject<bool?>();
+            if (isStatic.HasValue)
+            {
+                var desiredFlags = isStatic.Value ? (StaticEditorFlags)~0 : 0;
+                var currentFlags = GameObjectUtility.GetStaticEditorFlags(targetGo);
+
+                if (currentFlags != desiredFlags)
+                {
+                    GameObjectUtility.SetStaticEditorFlags(targetGo, desiredFlags);
+                    modified = true;
+                }
+            }
+
             Vector3? position = VectorParsing.ParseVector3(@params["position"]);
             Vector3? rotation = VectorParsing.ParseVector3(@params["rotation"]);
             Vector3? scale = VectorParsing.ParseVector3(@params["scale"]);

Server/src/cli/commands/gameobject.py

@@ -246,6 +246,11 @@ def create(
     default=None,
     help="Set active state."
 )
+@click.option(
+    "--static/--no-static",
+    default=None,
+    help="Set static flag (all StaticEditorFlags on/off)."
+)
 @click.option(
     "--add-components",
     default=None,
@@ -273,6 +278,7 @@ def modify(
     tag: Optional[str],
     layer: Optional[str],
     active: Optional[bool],
+    static: Optional[bool],
     add_components: Optional[str],
     remove_components: Optional[str],
     search_method: Optional[str],
@@ -288,6 +294,7 @@ def modify(
         unity-mcp gameobject modify "-81840" --search-method by_id --active
         unity-mcp gameobject modify "/Canvas/Panel" --search-method by_path --inactive
         unity-mcp gameobject modify "Cube" --add-components "Rigidbody,BoxCollider"
+        unity-mcp gameobject modify "Ground" --static
     """
     config = get_config()
 
@@ -312,6 +319,8 @@ def modify(
         params["layer"] = layer
     if active is not None:
         params["setActive"] = active
+    if static is not None:
+        params["isStatic"] = static
     if add_components:
         params["componentsToAdd"] = [c.strip() for c in add_components.split(",")]
     if remove_components:

Server/src/services/tools/manage_gameobject.py

@@ -87,6 +87,8 @@ async def manage_gameobject(
     set_active: Annotated[bool | str,
                           "If True, sets the GameObject active (accepts true/false or 'true'/'false')"] | None = None,
     layer: Annotated[str, "Layer name"] | None = None,
+    is_static: Annotated[bool | str,
+                         "Set the GameObject's static flag. true = all StaticEditorFlags, false = none (accepts true/false or 'true'/'false')"] | None = None,
     components_to_remove: Annotated[list[str] | str,
                                     "List of component names to remove"] | None = None,
     component_properties: Annotated[dict[str, dict[str, Any]] | str,
@@ -146,6 +148,7 @@ async def manage_gameobject(
     # --- Normalize boolean parameters ---
     save_as_prefab = coerce_bool(save_as_prefab)
     set_active = coerce_bool(set_active)
+    is_static = coerce_bool(is_static)
     world_space = coerce_bool(world_space, default=True)
 
     # --- Normalize component_properties with detailed error handling ---
@@ -182,6 +185,7 @@ async def manage_gameobject(
             "prefabFolder": prefab_folder,
             "setActive": set_active,
             "layer": layer,
+            "isStatic": is_static,
             "componentsToRemove": components_to_remove,
             "componentProperties": component_properties,
             # Parameters for 'duplicate'

Server/tests/integration/test_manage_gameobject_is_static.py

@@ -0,0 +1,135 @@
+import pytest
+
+from .test_helpers import DummyContext
+import services.tools.manage_gameobject as manage_go_mod
+
+
+@pytest.mark.asyncio
+async def test_manage_gameobject_is_static_true(monkeypatch):
+    """Test that is_static=True is passed as isStatic in params."""
+    captured = {}
+
+    async def fake_send(cmd, params, **kwargs):
+        captured["params"] = params
+        return {"success": True, "data": {}}
+
+    monkeypatch.setattr(
+        manage_go_mod,
+        "async_send_command_with_retry",
+        fake_send,
+    )
+
+    resp = await manage_go_mod.manage_gameobject(
+        ctx=DummyContext(),
+        action="modify",
+        target="Ground",
+        is_static=True,
+    )
+
+    assert resp.get("success") is True
+    assert captured["params"]["action"] == "modify"
+    assert captured["params"]["target"] == "Ground"
+    assert captured["params"]["isStatic"] is True
+
+
+@pytest.mark.asyncio
+async def test_manage_gameobject_is_static_false(monkeypatch):
+    """Test that is_static=False is passed as isStatic in params."""
+    captured = {}
+
+    async def fake_send(cmd, params, **kwargs):
+        captured["params"] = params
+        return {"success": True, "data": {}}
+
+    monkeypatch.setattr(
+        manage_go_mod,
+        "async_send_command_with_retry",
+        fake_send,
+    )
+
+    resp = await manage_go_mod.manage_gameobject(
+        ctx=DummyContext(),
+        action="modify",
+        target="Ground",
+        is_static=False,
+    )
+
+    assert resp.get("success") is True
+    assert captured["params"]["isStatic"] is False
+
+
+@pytest.mark.asyncio
+async def test_manage_gameobject_is_static_string_coercion(monkeypatch):
+    """Test that string 'true' is coerced to bool for is_static."""
+    captured = {}
+
+    async def fake_send(cmd, params, **kwargs):
+        captured["params"] = params
+        return {"success": True, "data": {}}
+
+    monkeypatch.setattr(
+        manage_go_mod,
+        "async_send_command_with_retry",
+        fake_send,
+    )
+
+    resp = await manage_go_mod.manage_gameobject(
+        ctx=DummyContext(),
+        action="modify",
+        target="Ground",
+        is_static="true",
+    )
+
+    assert resp.get("success") is True
+    assert captured["params"]["isStatic"] is True
+
+
+@pytest.mark.asyncio
+async def test_manage_gameobject_is_static_string_false_coercion(monkeypatch):
+    """Test that string 'false' is coerced to bool for is_static."""
+    captured = {}
+
+    async def fake_send(cmd, params, **kwargs):
+        captured["params"] = params
+        return {"success": True, "data": {}}
+
+    monkeypatch.setattr(
+        manage_go_mod,
+        "async_send_command_with_retry",
+        fake_send,
+    )
+
+    resp = await manage_go_mod.manage_gameobject(
+        ctx=DummyContext(),
+        action="modify",
+        target="Ground",
+        is_static="false",
+    )
+
+    assert resp.get("success") is True
+    assert captured["params"]["isStatic"] is False
+
+
+@pytest.mark.asyncio
+async def test_manage_gameobject_is_static_omitted(monkeypatch):
+    """Test that omitting is_static does not include isStatic in params."""
+    captured = {}
+
+    async def fake_send(cmd, params, **kwargs):
+        captured["params"] = params
+        return {"success": True, "data": {}}
+
+    monkeypatch.setattr(
+        manage_go_mod,
+        "async_send_command_with_retry",
+        fake_send,
+    )
+
+    resp = await manage_go_mod.manage_gameobject(
+        ctx=DummyContext(),
+        action="modify",
+        target="Ground",
+    )
+
+    assert resp.get("success") is True
+    assert "isStatic" not in captured["params"]