Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): add support for custom note share base url #386

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(ui): add support for custom note share base url #386

wants to merge 1 commit into from

Conversation

panjd123
Copy link

@panjd123 panjd123 commented Jan 9, 2025 •
edited
Loading

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@panjd123 panjd123 mentioned this pull request Jan 9, 2025
Open
3 tasks
CorentinTh
CorentinTh requested changes Jan 9, 2025
View reviewed changes
Copy link
Owner

@CorentinTh CorentinTh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @panjd123
Thanks for the PR 🙏

Small changes :
No need to .replace the origin of the generated url, you can simply pass your noteConfig to the usecase in https://github.com/CorentinTh/enclosed/blob/main/packages/app-client/src/modules/notes/notes.usecases.ts#L17

Just add an argument to the encryptAndCreateNote function

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
enclosed 🔨 Building (View Log) 0d302b9
enclosed-docs ✅ Ready (View Log) Visit Preview 0d302b9

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
enclosed-docs 🔨 Building (View Log) 0d302b9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CorentinTh CorentinTh CorentinTh requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panjd123 @CorentinTh