normalize, ARRAY: When items must be unique, ensure maxItems does not exceed the maximum number of item values.

Author: kerrykimbrough

tcases-lib/src/main/java/org/cornutum/tcases/resolve/Schemas.java

@@ -125,10 +125,27 @@ else if( schema.getEnum() != null)
         {
         case ARRAY:
           {
+          schema.setItems(
+            Optional.ofNullable( schema.getItems())
+            .map( items -> resultFor( "items", () -> normalize( items)))
+            .orElse( null));
+
           schema.setMaxItems(
             Optional.ofNullable( schema.getMaxItems())
             .filter( max -> max >= 0)
             .orElse( null));
+
+          domainSize( schema.getItems())
+            .filter( maxUnique -> Optional.ofNullable( schema.getUniqueItems()).orElse( false))
+            .filter( maxUnique -> Optional.ofNullable( schema.getMaxItems()).map( max -> max > maxUnique).orElse( true))
+            .ifPresent( maxUnique -> {
+
+              notifyError(
+                "maxItems exceeds the number of unique item values",
+                String.format("Adjusting maxItems to max unique items=%s", maxUnique));
+
+              schema.setMaxItems( maxUnique);
+              });
 
           schema.setMinItems(
             Optional.ofNullable( schema.getMinItems())

tcases-lib/src/test/java/org/cornutum/tcases/resolve/NormalizeSchemaTest.java

@@ -29,6 +29,7 @@ public void whenMinItemsAboveMax()
       .minItems( 10)
       .maxItems( 4)
       .uniqueItems( true)
+      .items( SchemaBuilder.type( "number").minimum( "0.0").maximum( "1.0").build())
       .build();
 
     Schema normalized =
@@ -151,6 +152,65 @@ public void whenMinItemsNegative()
     assertConditionsNone();
     }
 
+  @Test
+  public void whenMaxItemsNoneInfeasible()
+    {
+    // Given...
+    Schemas schemas = new Schemas( withConditionRecorder());
+
+    Schema schema =
+      SchemaBuilder.type( "array")
+      .uniqueItems( true)
+      .items( SchemaBuilder.type( "string").enums( "A", "B", "C").build())
+      .build();
+
+    Schema normalized =
+      SchemaBuilder.with( schema)
+      .build();
+    
+    // When...
+    normalized = schemas.normalize( normalized);
+    
+    // Then...
+    Schema expected =
+      SchemaBuilder.with( schema)
+      .maxItems( 3)
+      .build();
+
+    assertThat( "Normalized", normalized, matches( new SchemaMatcher( expected)));
+    assertErrors( "maxItems exceeds the number of unique item values. Adjusting maxItems to max unique items=3.");
+    }
+
+  @Test
+  public void whenMaxItemsInfeasible()
+    {
+    // Given...
+    Schemas schemas = new Schemas( withConditionRecorder());
+
+    Schema schema =
+      SchemaBuilder.type( "array")
+      .uniqueItems( true)
+      .maxItems( 4)
+      .items( SchemaBuilder.type( "string").enums( "A", "B", "C").build())
+      .build();
+
+    Schema normalized =
+      SchemaBuilder.with( schema)
+      .build();
+    
+    // When...
+    normalized = schemas.normalize( normalized);
+    
+    // Then...
+    Schema expected =
+      SchemaBuilder.with( schema)
+      .maxItems( 3)
+      .build();
+
+    assertThat( "Normalized", normalized, matches( new SchemaMatcher( expected)));
+    assertErrors( "maxItems exceeds the number of unique item values. Adjusting maxItems to max unique items=3.");
+    }
+
   @Test
   public void whenClassifierConstantEnum()
     {