requestRemovalLoopLimit breaks the maxRequestQueueSize logic

[almozavr]

Context

We set maxRequestQueueSize to some limit and we expect max requests size to not exceed this value (e.g. to avoid OutOfMemoryError)

Issue

SDK doesn't fulfil this promise and removes only requestRemovalLoopLimit at most. E.g. if a user has 1000 requests pending and our limit is 50, the sdk removes only 100 (value of requestRemovalLoopLimit) instead of 950.

[turtledreams]

Hi @almozavr,
That 100 should be applied for each request addition. So each time a new request is formed it would erase 100 request from the list if the list is larger than it should be. It was not working in your case? (PS. events are not formed into a request directly. They are queued and bundled into a single request with certain triggers)

[almozavr]

This logic doesn't work well on the app start when we initialize Countly. I mean it works exactly what we see in sdk code: so all the request minus requestRemovalLoopLimit are sent (in our case it causes OutOfMemoryError) - that number could be really huge. We expect maxRequestQueueSize is honoured, otherwise there is no good way to limit requests batch joined into the string.

[turtledreams]

I see, will add flag to disable gradual erasure of the queue which you can enable during init. Should be in next minor.

[turtledreams]

Hi @almozavr, just released and rc version with the init flag disableGradualRequestCleaner. Can you check and let me know if all issues are fixed for you.

[almozavr]

@turtledreams I've just looked through the code and it's exactly what we'd like to have, thanks!