[Sdk 632] Special character encoding exception fixed (#84)

* namespace added on countly classes

* special character encoding issue fixed!

* fixed import issue,
added a new assert

* auto -> char
comment added

* url encoding reverted to previous logic and fixed the issue.

* change log added

Author: ZahidZafar

CHANGELOG.md

@@ -3,6 +3,7 @@
 * !! Major breaking change !! We are extracting the 'Event' class out of the 'Countly' class which will change how that class can be referenced. 'Countly::Event' will not work, you will have to use 'cly::Event' instead.
 * !! Major breaking change !! Increased the compiler version required to compile the SDK. It's increased from version C++11 to C++14.
 * Making network requests has been reworked. They will now be sent on a separate thread. Requests will also be added in an internal queue and will be sent one at a time.
+* Fixed a bug that caused an exception on windows when encoding data that contains special characters. 
 
 22.02.0
 * Added 10-second time-outs for all windows HTTP transactions.

src/countly.cpp

@@ -702,11 +702,11 @@ std::chrono::system_clock::time_point Countly::getTimestamp() { return std::chro
 std::string Countly::encodeURL(const std::string &data) {
   std::ostringstream encoded;
 
-  for (auto character : data) {
+  for (unsigned char character : data) {
     if (std::isalnum(character) || character == '.' || character == '_' || character == '~') {
       encoded << character;
     } else {
-      encoded << '%' << std::setw(2) << std::hex << std::uppercase << (int)((unsigned char)character);
+      encoded << '%' << std::setw(2) << std::hex << std::setfill('0') << std::uppercase << (unsigned int)((unsigned char)character);
     }
   }
 

tests/main.cpp

@@ -119,8 +119,9 @@ HTTPCall popHTTPCall() {
 
 TEST_CASE("urlencoding is correct") {
   CHECK(Countly::encodeURL("hello world") == "hello%20world");
+  CHECK(Countly::encodeURL("hello.~world") == "hello.~world");
   CHECK(Countly::encodeURL("{\"key\":\"win\",\"count\":3}") == "%7B%22key%22%3A%22win%22%2C%22count%22%3A3%7D");
-  // CHECK(Countly::encodeURL("测试") == "%E6%B5%8B%E8%AF%95"); // UTF-8 TODO: Needs to be fixed. This is throwing an exception.
+  CHECK(Countly::encodeURL("测试") == "%E6%B5%8B%E8%AF%95");
 }
 
 #ifdef COUNTLY_USE_CUSTOM_SHA256