Macos compile issues fixed! (#97)

* compile issue fixed!

* destructor changes

* changes

* compile issue fixed on macos

Co-authored-by: Zahid Zafar <>

Author: ZahidZafar

src/countly.cpp

@@ -22,10 +22,6 @@ Countly::Countly() {
   views_module = nullptr;
   logger.reset(new cly::LoggerModule());
   configuration.reset(new cly::CountlyConfiguration("", ""));
-
-#if !defined(_WIN32) && !defined(COUNTLY_USE_CUSTOM_HTTP)
-  curl_global_init(CURL_GLOBAL_ALL);
-#endif
 }
 
 Countly::~Countly() {
@@ -34,10 +30,6 @@ Countly::~Countly() {
   crash_module.reset();
   views_module.reset();
   logger.reset();
-
-#if !defined(_WIN32) && !defined(COUNTLY_USE_CUSTOM_HTTP)
-  curl_global_cleanup();
-#endif
 }
 
 std::unique_ptr<Countly> _sharedInstance;

src/request_module.cpp

@@ -78,17 +78,32 @@ RequestModule::RequestModule(std::shared_ptr<CountlyConfiguration> config, std::
   impl.reset(new RequestModuleImpl(config, logger, requestBuilder));
 
   impl->_logger->log(LogLevel::DEBUG, cly::utils::format_string("[RequestModule] Initialized"));
+
+#if !defined(_WIN32) && !defined(COUNTLY_USE_CUSTOM_HTTP)
+  curl_global_init(CURL_GLOBAL_ALL);
+#endif
 }
 
-RequestModule::~RequestModule() { impl.reset(); }
+RequestModule::~RequestModule() {
+  impl.reset();
+#if !defined(_WIN32) && !defined(COUNTLY_USE_CUSTOM_HTTP) 
+  curl_global_cleanup();
+#endif 
+}
+
+static size_t countly_curl_write_callback(void *data, size_t byte_size, size_t n_bytes, std::string *body) {
+  size_t data_size = byte_size * n_bytes;
+  body->append((const char *)data, data_size);
+  return data_size;
+}
 
 void RequestModule::addRequestToQueue(const std::map<std::string, std::string> &data) {
   if (impl->_configuration->requestQueueThreshold <= impl->request_queue.size()) {
     impl->_logger->log(LogLevel::WARNING, cly::utils::format_string("[RequestModule] addRequestToQueue: Request Queue is full. Dropping the oldest request."));
     impl->request_queue.pop_front();
   }
 
-  std::string &request = impl->_requestBuilder->buildRequest(data);
+  const std::string &request = impl->_requestBuilder->buildRequest(data);
   impl->request_queue.push_back(request);
 }