[Sdk 661] Stop calling endsession on instance dispose (#44)

* Do not send endsession request on instance dispose

* function moved to top

* change log entry

* function name updated

* Change log updated

* PR Changes

* Update CHANGELOG.md

Co-authored-by: ArtursKadikis <[email protected]>

Author: ZahidZafar

CHANGELOG.md

@@ -3,6 +3,7 @@
 * ! Minor breaking change ! Default automatic session update duration changed to 60 seconds.
 * Added a call to change the automatic session update duration.
 * Fixed a bug where session duration was reported wrong.
+* Fixed a bug that caused an exception when the application quit. This was due to the SDK attempting to send an end session request.
 * Fixed an issue with the custom HTTP client function pointer by setting it's default value.
 * Fixed a bug that caused GET requests to fail on Linux.
 * Fixed bug when changing device id with server merge.

include/countly.hpp

@@ -213,6 +213,7 @@ class Countly {
 		_auto_session_update_interval = updateInterval;
 	}
 private:
+	void _deleteThread();
 	void log(LogLevel level, const std::string& message);
 
 	HTTPResponse sendHTTP(std::string path, std::string data);
@@ -234,6 +235,7 @@ class Countly {
 	int port;
 	bool use_https;
 	bool always_use_post;
+	bool is_being_disposed;
 	std::chrono::system_clock::time_point last_sent_session_request;
 	bool began_session;
 

src/countly.cpp

@@ -36,6 +36,7 @@ Countly::Countly() : max_events(COUNTLY_MAX_EVENTS_DEFAULT), wait_milliseconds(C
 	stop_thread = false;
 	began_session = false;
 	always_use_post = false;
+	is_being_disposed = false;
 	remote_config_enabled = false;
 
 	//Petting to null values
@@ -49,6 +50,7 @@ Countly::Countly() : max_events(COUNTLY_MAX_EVENTS_DEFAULT), wait_milliseconds(C
 }
 
 Countly::~Countly() {
+	is_being_disposed = true;
 	stop();
 #if !defined(_WIN32) && !defined(COUNTLY_USE_CUSTOM_HTTP)
 	curl_global_cleanup();
@@ -289,21 +291,26 @@ void Countly::startOnCloud(const std::string& app_key) {
 }
 
 void Countly::stop() {
+	_deleteThread();
+	if (began_session) {
+		endSession();
+	}
+}
+
+void Countly::_deleteThread() {
 	mutex.lock();
 	stop_thread = true;
 	mutex.unlock();
 	if (thread != nullptr && thread->joinable()) {
 		try {
 			thread->join();
-		} catch(const std::system_error& e) {
+		}
+		catch (const std::system_error& e) {
 			log(Countly::LogLevel::WARNING, "Could not join thread");
 		}
 		delete thread;
 		thread = nullptr;
 	}
-	if (began_session) {
-		endSession();
-	}
 }
 
 void Countly::setUpdateInterval(size_t milliseconds) {
@@ -607,6 +614,13 @@ bool Countly::endSession() {
 		{"timestamp", std::to_string(timestamp.count())},
 		{"end_session", "1"}
 	};
+
+	if (is_being_disposed) {
+		// if SDK is being destroyed, don't attempt to send the end-session request.
+		mutex.unlock();
+		return false;
+	}
+
 	if (sendHTTP("/i", Countly::serializeForm(data)).success) {
 		last_sent_session_request = now;
 		began_session = false;