Merge pull request #451 from Countly/fix_post_flutter_tests

mixed: support parallel run, sbs validation

Author: arifBurakDemiray

CHANGELOG.md

@@ -1,3 +1,10 @@
+## XX.XX.XX
+* Mitigated a race condition in the request queue that could drop or duplicate requests.
+* Mitigated an issue where server config defaults overrode user-provided SDK limits.
+* Mitigated an issue where invalid or unknown `sdkBehaviorSettings` keys were persisted.
+* Mitigated an issue where listing-filter conflicts cleared keys across unrelated categories.
+* Mitigated an issue where consent could be sent twice during initialization.
+
 ## 26.1.1
 * Added POST method support for contents. 
 * Added robust resource loading checks before displaying content

Countly.m

@@ -326,6 +326,8 @@ - (void)startWithConfig:(CountlyConfig *)config
         [self recordIndirectAttribution:config.indirectAttribution];
 
     [CountlyHealthTracker.sharedInstance sendHealthCheck];
+
+    CountlyCommon.sharedInstance.hasFinishedInit = YES;
 }
 
 - (CountlyConfig *) checkAndFixInternalLimitsConfig:(CountlyConfig *)config

CountlyCommon.h

@@ -80,6 +80,7 @@ extern NSString* const kCountlySDKName;
 @property (nonatomic, copy) NSString* SDKName;
 
 @property (nonatomic) BOOL hasStarted;
+@property (nonatomic) BOOL hasFinishedInit;
 @property (nonatomic) BOOL enableDebug;
 
 @property (nonatomic) BOOL shouldIgnoreTrustCheck;

CountlyCommon.m

@@ -70,6 +70,7 @@ - (void)resetInstance {
     [NSNotificationCenter.defaultCenter removeObserver:self name:UIDeviceOrientationDidChangeNotification object:nil];
 #endif
     _hasStarted = false;
+    _hasFinishedInit       = false;
     _maxKeyLength = kCountlyMaxKeyLength;
     _maxValueLength = kCountlyMaxValueSize;
     _maxSegmentationValues = kCountlyMaxSegmentationValues;

CountlyConnectionManager.m

@@ -18,6 +18,7 @@ @interface CountlyConnectionManager ()
 
 @property (nonatomic, strong) NSDate *startTime;
 @property (nonatomic, assign) atomic_bool backoff;
+@property (nonatomic, assign) atomic_bool isProcessingQueue;
 @property (nonatomic, strong) NSMutableDictionary<NSString *, CLYRequestCallback> *internalRequestCallbacks;
 @property (nonatomic, strong) NSMutableArray<CLYQueueFlushRunnable> *queueFlushRunnables;
 @property (nonatomic) BOOL hasAnyRequestFailed;
@@ -109,6 +110,7 @@ - (instancetype)init
         unsentSessionLength = 0.0;
         isSessionStarted = NO;
         atomic_init(&_backoff, NO);
+        atomic_init(&_isProcessingQueue, NO);
         _internalRequestCallbacks = [NSMutableDictionary dictionary];
         _queueFlushRunnables = [NSMutableArray array];
         _hasAnyRequestFailed = NO;
@@ -133,6 +135,7 @@ - (void)resetInstance {
         [self->_queueFlushRunnables removeAllObjects];
     });
     _hasAnyRequestFailed = NO;
+    atomic_store(&_isProcessingQueue, NO);
 }
 
 - (void)setHost:(NSString *)host
@@ -194,33 +197,37 @@ - (void)proceedOnQueue
         return;
     }
 
-    if (self.connection)
+    if (self.connection || atomic_exchange(&_isProcessingQueue, YES))
     {
         CLY_LOG_D(@"Proceeding on queue is aborted: Already has a request in process!");
         return;
     }
-    
+
     if (isCrashing)
     {
         CLY_LOG_D(@"Proceeding on queue is aborted: Application is crashing!");
+        atomic_store(&_isProcessingQueue, NO);
         return;
     }
-    
+
     if (self.isTerminating)
     {
         CLY_LOG_D(@"Proceeding on queue is aborted: Application is terminating!");
+        atomic_store(&_isProcessingQueue, NO);
         return;
     }
-    
+
     if (CountlyPersistency.sharedInstance.isQueueBeingModified)
     {
         CLY_LOG_D(@"Proceeding on queue is aborted: Queue is being modified!");
+        atomic_store(&_isProcessingQueue, NO);
         return;
     }
-    
+
     BOOL backoffFlag = atomic_load(&_backoff) ? YES : NO;
     if (backoffFlag) {
         CLY_LOG_I(@"%s, currently backed off, skipping proceeding the queue", __FUNCTION__);
+        atomic_store(&_isProcessingQueue, NO);
         return;
     }
 
@@ -263,6 +270,7 @@ - (void)proceedOnQueue
         // Reset start time and failure flag for future queue processing
         self.startTime = nil;
         self.hasAnyRequestFailed = NO;
+        atomic_store(&_isProcessingQueue, NO);
         return;
     }
 
@@ -272,17 +280,19 @@ - (void)proceedOnQueue
         [CountlyPersistency.sharedInstance removeFromQueue:firstItemInQueue];
 
         [CountlyPersistency.sharedInstance saveToFile];
-        
+
+        atomic_store(&_isProcessingQueue, NO);
         [self proceedOnQueue];
-        
+
         return;
     }
-    
+
 
     NSString* temporaryDeviceIDQueryString = [NSString stringWithFormat:@"&%@=%@", kCountlyQSKeyDeviceID, CLYTemporaryDeviceID];
     if ([firstItemInQueue containsString:temporaryDeviceIDQueryString])
     {
         CLY_LOG_D(@"Proceeding on queue is aborted: Device ID in request is CLYTemporaryDeviceID!");
+        atomic_store(&_isProcessingQueue, NO);
         return;
     }
 
@@ -360,6 +370,7 @@ - (void)proceedOnQueue
     self.connection = [self.URLSession dataTaskWithRequest:request completionHandler:^(NSData * data, NSURLResponse * response, NSError * error)
     {
         self.connection = nil;
+        atomic_store(&self->_isProcessingQueue, NO);
         NSDate *endTimeRequest = [NSDate date];
         long duration = (long)[endTimeRequest timeIntervalSinceDate:startTimeRequest];