iOS main thread for all functions and version updated. (#50)

* iOS main thread for all functions and version updated.

* Redundant main thread call removed from init.

Author: ijunaid

CHANGELOG.md

@@ -1,3 +1,6 @@
+## 20.11.5
+* iOS thread safety added to make all function calls on main thread.
+
 ## 20.11.4
 * Android session start issue fixed.
 * Updated underlying android SDK to 20.11.5

CountlyReactNative.podspec

@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name = 'CountlyReactNative'
-  s.version = '20.11.4'
+  s.version = '20.11.5'
   s.license = {
     :type => 'COMMUNITY',
     :text => <<-LICENSE

android/src/main/java/ly/count/android/sdk/react/CountlyReactNative.java

@@ -74,7 +74,7 @@ public String toString(){
 public class CountlyReactNative extends ReactContextBaseJavaModule implements LifecycleEventListener {
 
     public static final String TAG = "CountlyRNPlugin";
-    private String COUNTLY_RN_SDK_VERSION_STRING = "20.11.4";
+    private String COUNTLY_RN_SDK_VERSION_STRING = "20.11.5";
     private String COUNTLY_RN_SDK_NAME = "js-rnb-android";
 
     private static CountlyConfig config = new CountlyConfig();

example/install.sh

@@ -11,7 +11,7 @@ rm App.js
 curl https://raw.githubusercontent.com/Countly/countly-sdk-react-native-bridge/master/example/App.js --output App.js
 curl https://raw.githubusercontent.com/Countly/countly-sdk-react-native-bridge/master/example/Example.js --output Example.js
 
-yarn add [email protected].4
+yarn add [email protected].5
 
 cd ./ios
 pod install

ios/src/CountlyReactNative.m

@@ -21,7 +21,7 @@ @interface CountlyFeedbackWidget ()
 + (CountlyFeedbackWidget *)createWithDictionary:(NSDictionary *)dictionary;
 @end
 
-NSString* const kCountlyReactNativeSDKVersion = @"20.11.4";
+NSString* const kCountlyReactNativeSDKVersion = @"20.11.5";
 NSString* const kCountlyReactNativeSDKName = @"js-rnb-ios";
 
 CountlyConfig* config = nil;
@@ -44,35 +44,32 @@ @implementation CountlyReactNative
                  initWithResolver:(RCTPromiseResolveBlock)resolve
                  rejecter:(RCTPromiseRejectBlock)reject)
 {
-  NSString* serverurl = [arguments objectAtIndex:0];
-  NSString* appkey = [arguments objectAtIndex:1];
-  NSString* deviceID = [arguments objectAtIndex:2];
-
-  if (config == nil){
-    config = CountlyConfig.new;
-  }
-  
-  if(deviceID != nil && deviceID != (NSString *)[NSNull null] && ![deviceID  isEqual: @""]){
-    config.deviceID = deviceID;
-  }
-  config.appKey = appkey;
-  config.host = serverurl;
+  dispatch_async(dispatch_get_main_queue(), ^ {
+    NSString* serverurl = [arguments objectAtIndex:0];
+    NSString* appkey = [arguments objectAtIndex:1];
+    NSString* deviceID = [arguments objectAtIndex:2];
 
-  CountlyCommon.sharedInstance.SDKName = kCountlyReactNativeSDKName;
-  CountlyCommon.sharedInstance.SDKVersion = kCountlyReactNativeSDKVersion;
-  if(enablePushNotifications) {
-    [self addCountlyFeature:CLYPushNotifications];
-  }
+    if (config == nil){
+      config = CountlyConfig.new;
+    }
+    
+    if(deviceID != nil && deviceID != (NSString *)[NSNull null] && ![deviceID  isEqual: @""]){
+      config.deviceID = deviceID;
+    }
+    config.appKey = appkey;
+    config.host = serverurl;
 
-  if (serverurl != nil && [serverurl length] > 0) {
-      dispatch_async(dispatch_get_main_queue(), ^
-      {
-          [[Countly sharedInstance] startWithConfig:config];
-          
-          resolve(@"Success");
-      });
-  }
+    CountlyCommon.sharedInstance.SDKName = kCountlyReactNativeSDKName;
+    CountlyCommon.sharedInstance.SDKVersion = kCountlyReactNativeSDKVersion;
+    if(enablePushNotifications) {
+      [self addCountlyFeature:CLYPushNotifications];
+    }
 
+    if (serverurl != nil && [serverurl length] > 0) {
+      [[Countly sharedInstance] startWithConfig:config];
+      resolve(@"Success");
+    }
+  });
 }
 
 RCT_EXPORT_METHOD(event:(NSArray*)arguments)
@@ -226,6 +223,7 @@ - (void) saveListener:(Result) result{
 }
 RCT_EXPORT_METHOD(registerForNotification:(NSArray*)arguments)
 {
+  dispatch_async(dispatch_get_main_queue(), ^ {
     [self saveListener: ^(id  _Nullable result) {
          [self sendEventWithName:@"onCountlyPushNotification" body: [CountlyReactNative toJSON:lastStoredNotification]];
          lastStoredNotification = nil;
@@ -234,6 +232,8 @@ - (void) saveListener:(Result) result{
         [self sendEventWithName:@"onCountlyPushNotification" body: [CountlyReactNative toJSON:lastStoredNotification]];
         lastStoredNotification = nil;
     }
+  });
+    
 };
 
 + (void)onNotification:(NSDictionary *)notificationMessage

package.json

@@ -1,6 +1,6 @@
 {
   "name": "countly-sdk-react-native-bridge",
-  "version": "20.11.4",
+  "version": "20.11.5",
   "author": "Countly <[email protected]> (https://count.ly/)",
   "bugs": {
     "url": "https://github.com/Countly/countly-sdk-react-native-bridge/issues"