Implemented allowed intent class and package names for android push security (#94)

* Implemented allowed intent class and package names for android push notification security

* Update CountlyReactNative.java

Co-authored-by: ArtursKadikis <[email protected]>

Author: ijunaid

Countly.js

@@ -18,6 +18,7 @@ const Countly = {};
 Countly.serverUrl = "";
 Countly.appKey = "";
 _isInitialized = false;
+_isPushInitialized = false;
 /*
 * Listener for rating widget callback, when callback recieve we will remove the callback using listener. 
 */
@@ -200,6 +201,7 @@ Countly.askForNotificationPermission = function(customSoundPath = "null"){
         return message;
     }
     CountlyReactNative.askForNotificationPermission([customSoundPath]);
+    _isPushInitialized = true;
 }
 
 /**
@@ -212,6 +214,54 @@ Countly.registerForNotification = function(theListener){
     CountlyReactNative.registerForNotification([]);
     return event;
 };
+
+/**
+ * 
+ * Configure intent redirection checks for push notification
+ * Should be called before Countly "askForNotificationPermission"
+ * 
+ * @param {array of allowed class names } allowedIntentClassNames set allowed intent class names
+ * @param {array of allowed package names } allowedIntentClassNames set allowed intent package names
+ * @param {bool to check additional intent checks} useAdditionalIntentRedirectionChecks by default its true
+ */
+Countly.configureIntentRedirectionCheck = function(allowedIntentClassNames = [], allowedIntentPackageNames = [], useAdditionalIntentRedirectionChecks = true){
+    if (Platform.OS.match("ios")) return "configureIntentRedirectionCheck : not required for iOS";
+
+    if(_isPushInitialized) {
+        var message = "'configureIntentRedirectionCheck' must be called before 'askForNotificationPermission'";
+        Countly.logError("configureIntentRedirectionCheck", message);
+        return message;
+    }
+    if(!Array.isArray(allowedIntentClassNames)) {
+        var message = "Ignoring, unsupported data type '" + (typeof allowedIntentClassNames) + "' 'allowedIntentClassNames' should be an array of String";
+        Countly.logWarning("configureIntentRedirectionCheck", message);
+        allowedIntentClassNames = []
+    }
+    if(!Array.isArray(allowedIntentPackageNames)) {
+        var message = "Ignoring, unsupported data type '" + (typeof allowedIntentPackageNames) + "' 'allowedIntentPackageNames' should be an array of String";
+        Countly.logWarning("configureIntentRedirectionCheck", message);
+        allowedIntentPackageNames = []
+    }
+
+    if(typeof useAdditionalIntentRedirectionChecks != "boolean") {
+        var message = "Ignoring, unsupported data type '" + (typeof useAdditionalIntentRedirectionChecks) + "' 'useAdditionalIntentRedirectionChecks' should be a boolean";
+        Countly.logWarning("configureIntentRedirectionCheck", message);
+        useAdditionalIntentRedirectionChecks = true
+    }
+
+    var _allowedIntentClassNames = [];
+    for(var className of allowedIntentClassNames){
+        _allowedIntentClassNames.push(className.toString());
+    }
+
+    var _allowedIntentPackageNames = [];
+    for(var packageName of allowedIntentPackageNames){
+        _allowedIntentPackageNames.push(packageName.toString());
+    }
+
+    CountlyReactNative.configureIntentRedirectionCheck(_allowedIntentClassNames, _allowedIntentPackageNames, useAdditionalIntentRedirectionChecks);
+}
+
 // countly start for android
 Countly.start = function(){
     if(!_isInitialized) {

android/src/main/java/ly/count/android/sdk/react/CountlyReactNative.java

@@ -28,6 +28,7 @@
 import java.io.IOException;
 import java.io.InputStreamReader;
 import java.util.ArrayList;
+import java.util.Collection;
 import java.util.Collections;
 import java.util.List;
 import java.util.Set;
@@ -44,6 +45,7 @@
 import androidx.annotation.NonNull;
 
 import ly.count.android.sdk.StarRatingCallback;
+import ly.count.android.sdk.messaging.CountlyConfigPush;
 import ly.count.android.sdk.messaging.CountlyPush;
 
 
@@ -93,6 +95,11 @@ public class CountlyReactNative extends ReactContextBaseJavaModule implements Li
     private boolean isOnResumeBeforeInit = false;
     private Boolean isSessionStarted_ = false;
 
+
+    private List<String> allowedIntentClassNames = new ArrayList<>();
+    private List<String> allowedIntentPackageNames = new ArrayList<>();
+    private boolean useAdditionalIntentRedirectionChecks = true;
+
     private final ReactApplicationContext _reactContext;
 
     private final Set<String> validConsentFeatureNames = new HashSet<>(Arrays.asList(
@@ -587,8 +594,15 @@ public void askForNotificationPermission(ReadableArray args){
                 notificationManager.createNotificationChannel(channel);
             }
         }
-        CountlyPush.useAdditionalIntentRedirectionChecks = true;
-        CountlyPush.init(activity.getApplication(), messagingMode);
+        CountlyPush.useAdditionalIntentRedirectionChecks = useAdditionalIntentRedirectionChecks;
+        CountlyConfigPush configPush = new CountlyConfigPush(activity.getApplication(), messagingMode);
+        if(allowedIntentClassNames.size() > 0) {
+            configPush.setAllowedIntentClassNames(allowedIntentClassNames);
+        }
+        if(allowedIntentPackageNames.size() > 0) {
+            configPush.setAllowedIntentPackageNames(allowedIntentPackageNames);
+        }
+        CountlyPush.init(configPush);
         try{
             FirebaseApp.initializeApp(context);
             FirebaseMessaging firebaseMessagingInstance = FirebaseMessaging.getInstance();
@@ -620,6 +634,24 @@ public void onComplete(@NonNull Task<String> task) {
         }
     }
 
+    @ReactMethod
+    public void configureIntentRedirectionCheck(ReadableArray intentClassNames, ReadableArray intentPackageNames, boolean useAdditionalIntentRedirectionChecks){
+        Countly.sharedInstance();
+        this.useAdditionalIntentRedirectionChecks = useAdditionalIntentRedirectionChecks;
+        allowedIntentClassNames.clear();
+        allowedIntentPackageNames.clear();
+
+        for (int i = 0; i < intentClassNames.size(); i++) {
+            String className = intentClassNames.getString(i);
+            allowedIntentClassNames.add(className);
+        }
+
+        for (int i = 0; i < intentPackageNames.size(); i++) {
+            String packageName = intentPackageNames.getString(i);
+            allowedIntentPackageNames.add(packageName);
+        }
+    }
+
     @ReactMethod
     public void start(){
         if (isSessionStarted_) {

example/Example.js

@@ -65,6 +65,9 @@ class Example extends Component {
         else {
           Countly.enableAttribution(); // Enable to measure your marketing campaign performance by attributing installs from specific campaigns.
         }
+
+        Countly.configureIntentRedirectionCheck(["MainActivity"], ["com.countly.demo"]);
+        
         Countly.setStarRatingDialogTexts("Title", "Message", "Dismiss");
         await Countly.init("https://try.count.ly", "YOUR_APP_KEY"); // Initialize the countly SDK.
         Countly.appLoadingFinished();