Push service fixes (#76)

* Null checks added for application and context in push service

* Changes in messaging service

* SDK version updated

* Change linebreak to LF

* moving onNotification call to bottom

* Changelog update and sdk version updated

* Merge branch 'staging' of https://github.com/Countly/countly-sdk-react-native-bridge into pushServiceFixes

* Update CountlyMessagingService.java

* Update CountlyMessagingService.java

* Update CHANGELOG.md

* Update CountlyMessagingService.java

Co-authored-by: ArtursKadikis <[email protected]>

Author: ijunaid

CHANGELOG.md

@@ -1,3 +1,8 @@
+## 20.11.16
+* Fixed push notification issue where some apps were unable to display push notificaitons in their kill state.
+* Underlying android SDK version is 20.11.12
+* Underlying iOS SDK version is 20.11.3
+
 ## 20.11.15
 * Adding a mitigation when app is killed and received push notifications.
 * Underlying android SDK version is 20.11.12

CountlyReactNative.podspec

@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name = 'CountlyReactNative'
-  s.version = '20.11.15'
+  s.version = '20.11.16'
   s.license = {
     :type => 'COMMUNITY',
     :text => <<-LICENSE

android/src/main/java/ly/count/android/sdk/react/CountlyMessagingService.java

@@ -30,8 +30,6 @@ public void onMessageReceived(RemoteMessage remoteMessage) {
         if(Countly.sharedInstance().isLoggingEnabled()) {
             Log.d(Countly.TAG, "[CountlyMessagingService] got new message: " + remoteMessage.getData().toString());
         }
-        CountlyReactNative.onNotification(remoteMessage.getData());
-
 
         if(!Countly.sharedInstance().isInitialized()) {
             int mode = CountlyPush.getLastMessagingMethod(this);
@@ -72,10 +70,13 @@ public void onMessageReceived(RemoteMessage remoteMessage) {
                 Log.i(Countly.TAG, "[CountlyMessagingService] Message wasn't handled by Countly SDK because API level is too low for Notification support or because currentActivity is null (not enough lifecycle method calls)");
             }
         }
+        
+        // 'onNotification' should be called at the end of 'onMessageReceived'. This is due to an unknown issue that prevents showing notifications from the "killed" state for some app/hardware configurations
+        CountlyReactNative.onNotification(remoteMessage.getData());
     }
 
     @Override
     public void onDeletedMessages() {
         super.onDeletedMessages();
     }
-}
+}

android/src/main/java/ly/count/android/sdk/react/CountlyReactNative.java

@@ -75,7 +75,7 @@ public String toString(){
 public class CountlyReactNative extends ReactContextBaseJavaModule implements LifecycleEventListener {
 
     public static final String TAG = "CountlyRNPlugin";
-    private String COUNTLY_RN_SDK_VERSION_STRING = "20.11.15";
+    private String COUNTLY_RN_SDK_VERSION_STRING = "20.11.16";
     private String COUNTLY_RN_SDK_NAME = "js-rnb-android";
 
     private static CountlyConfig config = new CountlyConfig();

example/install.sh

@@ -11,7 +11,7 @@ rm App.js
 curl https://raw.githubusercontent.com/Countly/countly-sdk-react-native-bridge/master/example/App.js --output App.js
 curl https://raw.githubusercontent.com/Countly/countly-sdk-react-native-bridge/master/example/Example.js --output Example.js
 
-yarn add [email protected].15
+yarn add [email protected].16
 
 cd ./ios
 pod install

ios/src/CountlyReactNative.m

@@ -21,7 +21,7 @@ @interface CountlyFeedbackWidget ()
 + (CountlyFeedbackWidget *)createWithDictionary:(NSDictionary *)dictionary;
 @end
 
-NSString* const kCountlyReactNativeSDKVersion = @"20.11.15";
+NSString* const kCountlyReactNativeSDKVersion = @"20.11.16";
 NSString* const kCountlyReactNativeSDKName = @"js-rnb-ios";
 
 CountlyConfig* config = nil;

package.json

@@ -1,6 +1,6 @@
 {
   "name": "countly-sdk-react-native-bridge",
-  "version": "20.11.15",
+  "version": "20.11.16",
   "author": "Countly <[email protected]> (https://count.ly/)",
   "bugs": {
     "url": "https://github.com/Countly/countly-sdk-react-native-bridge/issues"