Skip to content

Windows 10 version being reported as Windows 8 under .NET Core #23

@christopher-rtf

Description

@christopher-rtf

Bug
The netstd project for countly-sdk-windows uses Environment.OSVersion to request the version of Windows (instead of System.Management like the .NET Framework SDK uses).

Under some installations of Windows 10, this function returns an OS version which is interpreted as Windows 8:
{Microsoft Windows NT 6.2.9200.0}

Consequently the metrics in Countly all show the OS users as Windows 8 users (even though they are usingWindows 10)

This bug is in ...\Entities\Device.cs's getOSInfo() function. This bug appears to be affecting more than half of our users.

Tested under
Tested under: Windows 10 Pro x64 (May 2020 update), under Parallels

Proposed resolution
As .NET Core now supports System.Management (and since I have confirmed that System Management does return the correct version # under Windows 10 and .NET Core), I recommend that the Countly SDK for Windows add the System.Management nuget package to the netstd project and reuse the pre-existing System.Management query code instead.

Notes from Microsoft on Environment.OSVersion (.NET Core 3.1 docs)
"The Environment.OSVersion property does not provide a reliable way to identify the exact operating system and its version. Therefore, we do not recommend that you use this method."
https://docs.microsoft.com/en-us/dotnet/api/system.environment.osversion?view=netcore-3.1

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions