Skip to content

Commit 1fc67b4

Browse files
authored
Merge pull request #5604 from Countly/anna/next
[SER-1791] UI fixes density/user-activity
2 parents fecf689 + 42fbd61 commit 1fc67b4

File tree

3 files changed

+7
-11
lines changed

3 files changed

+7
-11
lines changed

frontend/express/public/core/user-activity/javascripts/countly.views.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,12 +146,14 @@
146146

147147
var getUserLoyaltyView = function() {
148148
var tabsVuex = countlyVue.container.tabsVuex(["/analytics/loyalty"]);
149+
var templates = [];
150+
if (countlyGlobal.plugins.indexOf("drill") !== -1) {
151+
templates.push("/drill/templates/query.builder.v2.html");
152+
}
149153
return new countlyVue.views.BackboneWrapper({
150154
component: UserLoyaltyView,
151155
vuex: tabsVuex,
152-
templates: [
153-
"/drill/templates/query.builder.v2.html"
154-
]
156+
templates: templates
155157
});
156158
};
157159

plugins/density/frontend/public/templates/density.html

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,7 @@ <h4 data-test-id="densities-for-label">{{i18n('density.densities-for')}}</h4>
4646
</vue-scroll>
4747
</div>
4848
<h5 class="bu-pb-4" data-test-id="density-distribution-label"> {{i18n('density.distribution')}} </h5>
49-
<div v-if="densityVersions.length < 4 && !isLoading" class="technology-density-wrapper__versions-empty-card">
50-
<div class="text-medium" data-test-id="density-distribution-no-data-label">{{i18n('common.table.no-data')}}</div>
51-
</div>
52-
<div v-else-if="densityVersions.length === 0 && isLoading">
49+
<div v-if="densityVersions.length === 0 && isLoading">
5350
<div style="height: 200px;" v-loading="isLoading"></div>
5451
</div>
5552
<div v-else v-loading="isLoading" class="technology-density-wrapper__versions">
@@ -64,9 +61,6 @@ <h5 class="bu-pb-4" data-test-id="density-distribution-label"> {{i18n('density.d
6461
:scroll-ops="breakdownScrollOps"
6562
v-for="(item, idx) in densityVersions">
6663
</cly-metric-breakdown>
67-
<div v-if="densityItems.length < 4 && !isLoading" class="technology-density-wrapper__empty-card">
68-
<div class="text-medium">{{i18n('common.table.no-data')}}</div>
69-
</div>
7064
</cly-metric-cards>
7165
</vue-scroll>
7266
</div>

plugins/slipping-away-users/frontend/public/javascripts/countly.views.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
},
1818

1919
showDrillFilter: function() {
20-
if (countlyAuth.validateRead('drill')) {
20+
if (countlyAuth.validateRead('drill') && countlyGlobal.plugins.indexOf("drill") !== -1) {
2121
return true;
2222
}
2323
else {

0 commit comments

Comments
 (0)