Skip to content

Commit 3a122a0

Browse files
Merge branch 'next' into SER-1548
2 parents 2054df6 + 5b196f1 commit 3a122a0

File tree

25 files changed

+577
-514
lines changed

25 files changed

+577
-514
lines changed

CHANGELOG.md

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,18 @@
1+
## Version 24.05.11
2+
Fixes:
3+
- [cache] Use a cursor without timeout
4+
5+
## Version 24.05.10
6+
Fixes:
7+
- [alerts] Alerts improvements
8+
- [core] Various fixes for frontend to support running countly from subdirectory
9+
- [logs] Show collected problems on logger
10+
11+
Enterprise fixes:
12+
- [data-manager] Fixes n UI to allow events starting with "/"
13+
- [flows] Fixes for flows step generation
14+
- [surveys] Other is not allowed as a valid answer for required questions
15+
116
## Version 24.05.9
217
Fixes:
318
- [crashes] Fix crashes template paths and add data check

api/parts/data/cache.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -971,7 +971,7 @@ class StreamedCollection {
971971
let [col, last] = await createCollection(this.db, this.name, 1e7);
972972

973973
this.col = col;
974-
this.stream = col.find({_id: {$gt: last}}, {tailable: true, awaitData: true, numberOfRetries: -1}).stream();
974+
this.stream = col.find({_id: {$gt: last}}, {tailable: true, awaitData: true, noCursorTimeout: true, numberOfRetries: -1}).stream();
975975

976976
this.stream.on('data', doc => {
977977
if (this.inserts.indexOf(doc._id.toString()) !== -1) {

frontend/express/public/core/app-management/templates/app-management.html

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,27 @@ <h3 class="bu-mb-2" v-if="!newApp && hasAppAdminRights">{{i18n('management-appli
364364
</cly-inline-form-field>
365365
</el-collapse-item>
366366
</el-collapse>
367-
<cly-diff-helper :diff="changeKeys" @discard="onDiscard" @save="saveSettings" :disabled="v.invalid" :emitSaveWhenDisabled="true"></cly-diff-helper>
367+
<cly-diff-helper :diff="changeKeys" @discard="onDiscard" @save="saveSettings" :disabled="v.invalid" :emitSaveWhenDisabled="true" :isModal=true>
368+
<template v-slot:main>
369+
<div class="bu-mr-0 bu-is-flex bu-is-justify-content-flex-end bu-is-align-items-center cly-vue-user-selected" style="height: 100%;">
370+
<span class="selected-count-blue bu-pl-1 text-medium">
371+
<span style="background-color:#0166D6; color:white; padding:3px 7px; border-radius:4px;">{{changeKeys.length}}</span>
372+
<span class="bu-is-lowercase text-medium color-cool-gray-50 bu-pl-1">{{ i18n("common.diff-helper.changes-made") }}</span>
373+
<span class="text-medium color-cool-gray-50">{{ i18n("common.diff-helper.keep") }}</span>
374+
</span>
375+
<span class="vertical-divider bu-mr-4 bu-ml-4"></span>
376+
<el-button skin="red" class="bu-mr-2" size="small" type="default" @click="saveSettings">
377+
<i class="cly-io-16 cly-io cly-io-save" style="font-size: larger;"></i>
378+
<span class="bu-ml-1">
379+
{{ i18n('dashboards.save-changes') }}
380+
</span>
381+
</el-button>
382+
<el-button class="x-button" @click="onDiscard">
383+
<i class="cly-io-16 cly-io cly-io-x color-cool-gray-50"></i>
384+
</el-button>
385+
</div>
386+
</template>
387+
</cly-diff-helper>
368388
</validation-observer>
369389
</cly-section>
370390
<el-card class="box-card color-cool-gray-100" v-if="!newApp && isCode">

frontend/express/public/core/events/javascripts/countly.details.views.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* global countlyVue, countlyGlobal, countlyAllEvents, countlyCommon, CV,app*/
1+
/* global countlyVue, countlyGlobal, countlyAllEvents, countlyCommon, CountlyHelpers, CV,app*/
22
(function() {
33
var EventsTable = countlyVue.views.create({
44
template: CV.T("/core/events/templates/eventsTable.html"),
@@ -400,9 +400,10 @@
400400
clyModel: countlyAllEvents
401401
}],
402402
});
403-
app.route("/analytics/events/key/:eventKey", "events", function(eventKey) {
403+
app.route("/analytics/events/key/*eventKey", "events", function(query) {
404+
var queryUrlParameter = query && CountlyHelpers.isJSON(query) ? JSON.parse(query) : query;
404405
var params = {
405-
eventKey: eventKey
406+
eventKey: queryUrlParameter
406407
};
407408
var eventsViewWrapper = getAllEventsView();
408409
eventsViewWrapper.params = params;

frontend/express/public/core/events/javascripts/countly.overview.views.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
},
1313
methods: {
1414
onRowClick: function(params) {
15-
app.navigate("#/analytics/events/key/" + params.key, true);
15+
app.navigate("#/analytics/events/key/" + JSON.stringify(params.key), true);
1616
},
1717
formatNumber: function(val) {
1818
return countlyCommon.formatNumber(val);
@@ -243,7 +243,7 @@
243243
this.$store.dispatch('countlyEventsOverview/fetchMonitorEvents');
244244
},
245245
onMetricClick: function(params) {
246-
app.navigate("#/analytics/events/key/" + params.key, true);
246+
app.navigate("#/analytics/events/key/" + JSON.stringify(params.key), true);
247247
},
248248
durCheck: function(item) {
249249
var eventMapKey = item.eventKey;

frontend/express/public/javascripts/countly/vue/components/dropdown.js

Lines changed: 23 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -529,8 +529,9 @@
529529
template: '<cly-dropdown class="cly-vue-more-options" ref="dropdown" :placement="placement" :disabled="disabled" v-on="$listeners">\
530530
<template v-slot:trigger>\
531531
<slot name="trigger">\
532-
<el-button :data-test-id="testId + \'-more-option-button\'" :size="size" :icon="icon" :type="type">\
533-
<span :data-test-id="testId + \'-more-option-text\'" v-if="text">{{text}}</span>\
532+
<el-button :data-test-id="testId + \'-more-option-button\'" :size="size" :icon="icon" :type="type" @click="toggleArrowState">\
533+
<span :data-test-id="testId + \'-more-option-text\'" v-if="text">{{text}}</span>\
534+
<i v-if="showArrows" class="el-select__caret" :class="[iconClass]"></i>\
534535
</el-button>\
535536
</slot>\
536537
</template>\
@@ -567,16 +568,36 @@
567568
testId: {
568569
type: String,
569570
default: 'cly-more-options-test-id'
571+
},
572+
showArrows: {
573+
type: Boolean,
574+
default: false
570575
}
571576
},
577+
data: function() {
578+
return {
579+
arrowState: false,
580+
};
581+
},
572582
mounted: function() {
573583
this.$on('menu-item-click', this.handleMenuItemClick);
574584
},
585+
computed: {
586+
iconClass: function() {
587+
return this.arrowState ? 'ion-arrow-up-b is-reverse' : 'ion-arrow-up-b';
588+
},
589+
},
575590
methods: {
576591
handleMenuItemClick: function(command, instance) {
577592
if (!this.disabled) {
578593
this.$emit('command', command, instance);
579594
this.$refs.dropdown.handleClose();
595+
this.arrowState = false;
596+
}
597+
},
598+
toggleArrowState: function() {
599+
if (!this.disabled) {
600+
this.arrowState = !this.arrowState;
580601
}
581602
}
582603
},

frontend/express/public/localization/dashboard/dashboard.properties

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,7 @@ common.undo = Undo
261261
common.drawer.next-step = Next step
262262
common.drawer.previous-step = Previous step
263263
common.diff-helper.changes = You made {0} changes.
264+
common.diff-helper.changes-made = changes have been made.
264265
common.diff-helper.keep = Do you want to keep them?
265266
common.save-changes = Save Changes
266267
common.discard-changes = Discard

frontend/express/public/stylesheets/styles/blocks/_dropdown.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -175,5 +175,9 @@
175175
.cly-vue-more-options {
176176
.el-button {
177177
border: 1px solid #CFD6E4;
178+
.is-reverse {
179+
-webkit-transform: rotateZ(0);
180+
transform: rotateZ(0);
181+
}
178182
}
179183
}

0 commit comments

Comments
 (0)