Skip to content

Commit 4c55a94

Browse files
Merge pull request #5697 from Countly/SER-1551
[SER-1551] Frontend auth. Fix insufficient null checks
2 parents 1c3559c + a0c2384 commit 4c55a94

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

frontend/express/public/javascripts/countly/countly.auth.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
}
4040

4141
if (!member.global_admin) {
42-
var isPermissionObjectExistForAccessType = (typeof member.permission[accessType] === "object" && typeof member.permission[accessType][app_id] === "object");
42+
var isPermissionObjectExistForAccessType = (member.permission && typeof member.permission[accessType] === "object" && typeof member.permission[accessType][app_id] === "object");
4343

4444
var memberHasAllFlag = member.permission && member.permission[accessType] && member.permission[accessType][app_id] && member.permission[accessType][app_id].all;
4545
var memberHasAllowedFlag = false;
@@ -96,7 +96,7 @@
9696
return false;
9797
}
9898
if (!member.global_admin) {
99-
var isPermissionObjectExistForRead = (typeof member.permission.r === "object" && typeof member.permission.r[app_id] === "object");
99+
var isPermissionObjectExistForRead = (member.permission && typeof member.permission.r === "object" && typeof member.permission.r[app_id] === "object");
100100
// TODO: make here better. create helper method for these checks
101101
var memberHasAllFlag = member.permission && member.permission.r && member.permission.r[app_id] && member.permission.r[app_id].all;
102102
var memberHasAllowedFlag = false;

0 commit comments

Comments
 (0)