Skip to content

Commit 4f84d32

Browse files
authored
Merge pull request #5622 from Countly/SER-683
[SER-683] [Fix] Ability to go to Drill from events and views table
2 parents b551e81 + 499e87c commit 4f84d32

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

frontend/express/public/core/events/javascripts/countly.details.views.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -178,11 +178,8 @@
178178
byVal: [],
179179
executed: false
180180
};
181-
if (doc.selectedSegment !== "segment") {
182-
URLparams.dbFilter[`sg.${doc.selectedSegment}`] = { "$in": [] };
183-
if (doc.selectedSegmentValues.length > 0) {
184-
URLparams.dbFilter[`sg.${doc.selectedSegment}`].$in = doc.selectedSegmentValues;
185-
}
181+
if (doc.selectedSegment !== "segment" && doc.selectedSegmentValues.length > 0) {
182+
URLparams.dbFilter[`sg.${doc.selectedSegment}`] = { "$in": doc.selectedSegmentValues };
186183
}
187184
//Go to drill page
188185
app.navigate("#/drill/" + JSON.stringify(URLparams), true);

plugins/views/frontend/public/javascripts/countly.views.js

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,15 @@
185185
URLparams.dbFilter[`sg.name`] = { "$in": doc.selectedViews };
186186
}
187187
if (doc.selectedSegment !== "all" && doc.selectedSegmentValues.length > 0) {
188-
URLparams.dbFilter[`sg.${doc.selectedSegment}`] = { "$in": doc.selectedSegmentValues };
188+
if (doc.selectedSegment === "segment" || doc.selectedSegment === "platform") {
189+
URLparams.dbFilter.$or = [
190+
{ "sg.platform": { "$in": doc.selectedSegmentValues } },
191+
{ "sg.segment": { "$in": doc.selectedSegmentValues } }
192+
];
193+
}
194+
else {
195+
URLparams.dbFilter[`sg.${doc.selectedSegment}`] = { "$in": doc.selectedSegmentValues };
196+
}
189197
}
190198
//Go to drill page
191199
app.navigate("#/drill/" + JSON.stringify(URLparams), true);

0 commit comments

Comments
 (0)