Merge pull request #6411 from Countly/mongo-url-parse

[core] Fix mongo connection url parsing

Author: widatama

CHANGELOG.md

@@ -1,3 +1,7 @@
+## Version 25.03.XX
+Fixes:
+- [core] Fix mongo connection url parsing
+
 ## Version 25.03.10
 Enterprise Fixes:
 - [okta] Fix body parser middleware version mismatch causing OKTA authentication break

plugins/pluginManager.js

@@ -11,7 +11,6 @@ var pluginDependencies = require('./pluginDependencies.js'),
     apiCountlyConfig = require('../api/config', 'dont-enclose'),
     utils = require('../api/utils/utils.js'),
     fs = require('fs'),
-    url = require('url'),
     querystring = require('querystring'),
     cp = require('child_process'),
     async = require("async"),
@@ -1877,9 +1876,21 @@ var pluginManager = function pluginManager() {
         }
 
         if (config && typeof config.mongodb === "string") {
-            var urlParts = url.parse(config.mongodb, true);
-            if (urlParts && urlParts.query && urlParts.query.maxPoolSize) {
-                maxPoolSize = urlParts.query.maxPoolSize;
+            try {
+                const urlObj = new URL(config.mongodb);
+                // mongo connection string with multiple host like 'mongodb://localhost:30000,localhost:30001' will cause an error
+
+                maxPoolSize = urlObj.searchParams.get('maxPoolSize') !== null ? urlObj.searchParams.get('maxPoolSize') : maxPoolSize;
+            }
+            catch (_err) {
+                // we catch the error here and try to process only the query params part
+                const urlParts = config.mongodb.split('?');
+
+                if (urlParts.length > 1) {
+                    const queryParams = new URLSearchParams(urlParts[1]);
+
+                    maxPoolSize = queryParams.get('maxPoolSize') !== null ? queryParams.get('maxPoolSize') : maxPoolSize;
+                }
             }
         }
         else {