Skip to content

Commit 84b74fd

Browse files
authored
Merge pull request #6480 from Countly/adding-warning-tags-to-settings
fix: ui test fixing for warning tags added to settings
2 parents ed0e1d2 + 860751a commit 84b74fd

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

plugins/plugins/frontend/public/templates/configurations.html

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,13 @@ <h3 v-if="predefinedStructure[selectedConfig].groups.length > 1 || group.label"
5151
v-for="key in group.list" :key="key"
5252
class="bu-columns bu-is-vcentered bu-p-5 config-section">
5353
<div class="bu-column bu-is-7">
54-
<div class="bu-has-text-weight-medium bu-is-flex bu-is-align-items-center config-section__header" :data-test-id="'settings-title-label-' + key.toLowerCase().replaceAll('_', '-')">
54+
<div class="bu-has-text-weight-medium bu-is-flex bu-is-align-items-center config-section__header">
5555
<div>
56-
<span class="bu-mr-2"> {{ getLabelName(key) }} </span>
56+
<span class="bu-mr-2" :data-test-id="'settings-title-label-' + key.toLowerCase().replaceAll('_', '-')"> {{ getLabelName(key) }} </span>
5757
</div>
58-
<div class="bu-is-flex bu-is-align-items-center">
58+
<div
59+
class="bu-is-flex bu-is-align-items-center"
60+
>
5961
<div
6062
v-for="(tag, index) in getWarningTags(selectedConfig, key)"
6163
:key="index"

ui-tests/cypress/lib/dashboard/manage/configurations/configurations.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,13 +179,13 @@ const verifyPageElements = () => {
179179
attrText: "100"
180180
});
181181

182+
cy.scrollPageToCenter();
183+
182184
cy.verifyElement({
183185
labelElement: configurationsListBoxElements({subFeature: SETTINGS.API.DATA_LIMITS.EVENT_SEGMENTATION_VALUE_LIMIT}).SELECTED_SUBFEATURE_TITLE,
184186
labelText: "Max unique values in each segmentation",
185187
});
186188

187-
cy.scrollPageToCenter();
188-
189189
cy.verifyElement({
190190
labelElement: configurationsListBoxElements({subFeature: SETTINGS.API.DATA_LIMITS.EVENT_SEGMENTATION_VALUE_LIMIT}).SELECTED_SUBFEATURE_DESCRIPTION,
191191
labelText: "Maximum number of unique values in each segmentation. Increasing this number may affect your server performance.",

0 commit comments

Comments
 (0)