Skip to content

Commit ba34259

Browse files
committed
improve error reportings for hook
1 parent afd822c commit ba34259

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

plugins/hooks/api/api.js

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -496,8 +496,8 @@ plugins.register("/o/hook/list", function(ob) {
496496
});
497497
}
498498
catch (err) {
499-
log.e('get hook list failed');
500-
common.returnMessage(params, 500, "Failed to get hook list");
499+
log.e('get hook list failed', { error: err });
500+
common.returnMessage(params, 500, "Failed to get hook list" + err.message);
501501
}
502502
}, paramsInstance);
503503
return true;
@@ -545,6 +545,9 @@ plugins.register("/i/hook/status", function(ob) {
545545
data: { updatedHooksCount: Object.keys(statusList).length, requestedBy: params.member._id }
546546
});
547547
common.returnOutput(params, true);
548+
}).catch(function(err) {
549+
log.e('Failed to update hook statuses: ', { error: err }); // Hata detaylarını logla
550+
common.returnMessage(params, 500, "Failed to update hook statuses: " + err.message); // Hata mesajını döndür
548551
});
549552
}, paramsInstance);
550553
return true;
@@ -593,8 +596,8 @@ plugins.register("/i/hook/delete", function(ob) {
593596
);
594597
}
595598
catch (err) {
596-
log.e('delete hook failed', hookID);
597-
common.returnMessage(params, 500, "Failed to delete an hook");
599+
log.e('delete hook failed', { hookID, error: err });
600+
common.returnMessage(params, 500, "Failed to delete an hook" + err.message);
598601
}
599602
}, paramsInstance);
600603
return true;
@@ -617,7 +620,7 @@ plugins.register("/i/hook/test", function(ob) {
617620
const mockData = JSON.parse(params.qstring.mock_data);
618621

619622
if (!(common.validateArgs(hookConfig, CheckHookProperties(hookConfig)))) {
620-
common.returnMessage(params, 403, "hook config invalid");
623+
common.returnMessage(params, 403, "hook config invalid" + JSON.stringify(hookConfig));
621624
}
622625

623626
if (hookConfig.effects && !validateEffects(hookConfig.effects)) {
@@ -675,8 +678,8 @@ plugins.register("/i/hook/test", function(ob) {
675678
return false;
676679
}
677680
catch (e) {
678-
log.e("hook test error", e);
679-
common.returnMessage(params, 503, "Hook test failed.");
681+
log.e("hook test error", { error: e, hookConfig });
682+
common.returnMessage(params, 503, "Hook test failed." + e.message);
680683
return;
681684
}
682685
}, paramsInstance);

0 commit comments

Comments
 (0)