Skip to content

Commit bc57624

Browse files
authored
Merge pull request #6165 from Countly/24.05->24.10-merge
24.05->24.10
2 parents a6e50ac + 9a8d4cc commit bc57624

File tree

4 files changed

+19
-5
lines changed

4 files changed

+19
-5
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
1+
12
## Version 24.10.x
23
Features:
34
- [crashed] Fix unescaped SDK logs
45
- [dashboards] Added the option to set a refresh rate for dashboards, allowing data to update more frequently for selected dashboards
56
- [star-rating] Added missing columns to Rating Widgets table edit
67
- [ui] Fix alignment of drawers title and close icon
8+
- [feedback] Uniformize drawer internal name input texts
9+
- [star-rating] Fix rating score and responses table sorting
710

811
## Version 24.10.9
912
Fixes:

plugins/alerts/frontend/public/javascripts/countly.models.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -227,6 +227,17 @@
227227
ret.segments = eventData.segments;
228228
}
229229
}
230+
for (var key in ret.segments) {
231+
//Copy all containing : to . This is hotfix for cases when we have '.' in key. Will not distinguish in case there is '.' and ":" in same structure key.
232+
if (key.indexOf(":") > -1) {
233+
//replace all : with .
234+
var key2 = key.replace(/:/g, ".");
235+
ret.segments[key2] = [];
236+
for (var k = 0; k < ret.segments[key].length; k++) {
237+
ret.segments[key2].push(ret.segments[key][k]);
238+
}
239+
}
240+
}
230241
callback(ret);
231242
});
232243
};

plugins/star-rating/frontend/public/localization/star-rating.properties

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,8 @@ feedback.where-to-collect-feedback = Where to collect ratings?
113113
feedback.all-pages = On all pages
114114
feedback.selected-pages = On selected pages
115115
feedback.internalName = Internal Name
116-
feedback.internalName.placeholder = Widget Name
117-
feedback.internalName.description = Name survey for internal purposes. It is not going to be shown on survey.
116+
feedback.internalName.placeholder = Enter a internal Name
117+
feedback.internalName.description = This name is internal and will not be shown to your end user.
118118
feedback.consent = Add user consent
119119
feedback.question = Question
120120
feedback.rating-symbol = Rating Symbol
@@ -207,4 +207,4 @@ rating.drawer.consent.text = Text
207207
rating.drawer.consent.placeholder = I agree to terms & conditions and privacy policy
208208
rating.drawer.consent.links = Link(s)
209209
rating.drawer.consent.add.link = + Add link
210-
rating.drawer.links.tooltip = Matching link texts inside the consent text are modified to be links
210+
rating.drawer.links.tooltip = Matching link texts inside the consent text are modified to be links

plugins/star-rating/frontend/public/templates/widgets-table.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@
9898
column-key="ratingsCount"
9999
:label="i18n('feedback.responses')"
100100
min-width="130"
101-
prop="responses"
101+
prop="ratingsCount"
102102
sortable="true"
103103
>
104104
<template
@@ -119,7 +119,7 @@
119119
column-key="ratingScore"
120120
:label="i18n('feedback.rating-score')"
121121
min-width="150"
122-
prop="rating_score"
122+
prop="ratingScore"
123123
sortable="true"
124124
>
125125
<template

0 commit comments

Comments
 (0)