Merge pull request #5497 from Countly/SER-1540

ArtursKadikis · web-flow · commit c470ccfbd757 · 2024-09-17T17:33:39.000+03:00
[SER-1540] [Deepscan] Helpers. Expression '"_on_"' evaluates to a non-numeric string value, which is converted to numeric value 'NaN' at unary '+' operator.
diff --git a/frontend/express/public/javascripts/countly/countly.helpers.js b/frontend/express/public/javascripts/countly/countly.helpers.js
@@ -1250,7 +1250,7 @@
             }
             else {
                 //include export date
-                name += +"_on_" + moment().format("DD-MMM-YYYY");
+                name += "_on_" + moment().format("DD-MMM-YYYY");
             }
             return (name.charAt(0).toUpperCase() + name.slice(1).toLowerCase());
         }

Original file line number	Diff line number	Diff line change
`@@ -1250,7 +1250,7 @@`
`1250`	`1250`	`}`
`1251`	`1251`	`else {`
`1252`	`1252`	`//include export date`
`1253`		`- name += +"_on_" + moment().format("DD-MMM-YYYY");`
	`1253`	`+ name += "_on_" + moment().format("DD-MMM-YYYY");`
`1254`	`1254`	`}`
`1255`	`1255`	`return (name.charAt(0).toUpperCase() + name.slice(1).toLowerCase());`
`1256`	`1256`	`}`