Merge pull request #5500 from Countly/SER-1548

ArtursKadikis · web-flow · commit ec8881f05f20 · 2024-09-18T17:48:54.000+03:00
[SER-1548] [Deepscan] Token-manager. Loop with splice should be rewriten to preven out of bounds error
diff --git a/frontend/express/public/core/token-manager/javascripts/countly.views.js b/frontend/express/public/core/token-manager/javascripts/countly.views.js
@@ -123,6 +123,7 @@
                 for (var j = 0; j < tableData.length; j++) {
                     if (tableData[j]._id === countlyGlobal.auth_token) {
                         tableData.splice(j, 1);
+                        j--;
                     }
                 }
                 for (var i = 0; i < tableData.length; i++) {

Original file line number	Diff line number	Diff line change
`@@ -123,6 +123,7 @@`
`123`	`123`	`for (var j = 0; j < tableData.length; j++) {`
`124`	`124`	`if (tableData[j]._id === countlyGlobal.auth_token) {`
`125`	`125`	`tableData.splice(j, 1);`
	`126`	`+ j--;`
`126`	`127`	`}`
`127`	`128`	`}`
`128`	`129`	`for (var i = 0; i < tableData.length; i++) {`