Merge pull request #6479 from Countly/crash-stats

[SER-2499] [crashes] Fix trend and change calculation

Author: widatama

CHANGELOG.md

@@ -8,6 +8,7 @@ Fixes:
 - [core] Use correct rights validation for loyality
 - [crashes] Fix free session for home widget
 - [crashes] Use na for free session and free user when there's no data
+- [crashes] Fix trend and change calculation for crash stats
 
 Enterprise Fixes:
 - [ldap] Error handling in ldap plugin on search error

plugins/crashes/frontend/public/javascripts/countly.models.js

@@ -169,12 +169,18 @@ function transformAppVersion(inpVersion) {
                 else if (dashboard[metric].total !== 0 && dashboard[metric]["prev-total"] === 0) {
                     dashboard[metric].change = "∞";
                 }
+                else if (dashboard[metric].total === dashboard[metric]["prev-total"]) {
+                    dashboard[metric].change = "0";
+                }
 
                 if (dashboard[metric].total === dashboard[metric]["prev-total"]) {
                     dashboard[metric].trend = "n";
                 }
                 else {
-                    dashboard[metric].trend = dashboard[metric].total >= dashboard[metric]["prev-total"] ? "u" : "d";
+                    var totl = dashboard[metric].total === 'NA' ? -1 : dashboard[metric].total;
+                    var prevTotl = dashboard[metric]['prev-total'] === 'NA' ? -1 : dashboard[metric]['prev-total'];
+
+                    dashboard[metric].trend = totl >= prevTotl ? 'u' : 'd';
                 }
 
                 if (metric in derivations) {

ui-tests/cypress/lib/dashboard/crashes/crashes.js

@@ -563,7 +563,7 @@ const verifyCrashStatisticsEChartElements = ({
 
         cy.verifyElement({
             labelElement: crashStatisticsEChartElements.TOTAL_OCCURENCES_CHANGE_VALUE_LABEL,
-            labelText: "NA",
+            labelText: "0",
         });
 
         cy.verifyElement({
@@ -573,7 +573,7 @@ const verifyCrashStatisticsEChartElements = ({
 
         cy.verifyElement({
             labelElement: crashStatisticsEChartElements.TOTAL_OCCURENCES_CHANGE_VALUE_LABEL,
-            labelText: "NA",
+            labelText: "0",
         });
 
         cy.verifyElement({
@@ -583,22 +583,22 @@ const verifyCrashStatisticsEChartElements = ({
 
         cy.verifyElement({
             labelElement: crashStatisticsEChartElements.CRASH_FREE_USERS_NUMBER_LABEL,
-            labelText: "100.00%",
+            labelText: "NA",
         });
 
         cy.verifyElement({
             labelElement: crashStatisticsEChartElements.CRASH_FREE_USERS_CHANGE_VALUE_LABEL,
-            labelText: "0.0%",
+            labelText: "NA",
         });
 
         cy.verifyElement({
             labelElement: crashStatisticsEChartElements.CRASH_FREE_SESSIONS_NUMBER_LABEL,
-            labelText: "100.00%",
+            labelText: "NA",
         });
 
         cy.verifyElement({
             labelElement: crashStatisticsEChartElements.CRASH_FREE_SESSIONS_CHANGE_VALUE_LABEL,
-            labelText: "0.0%",
+            labelText: "NA",
         });
         return;
     }
@@ -686,4 +686,4 @@ module.exports = {
     verifyCrashGroupsDataFromTable,
     verifyCrashStatisticsMetricCard,
     verifyCrashStatisticsEChartElements
-};
+};

ui-tests/cypress/lib/dashboard/home/home.js

@@ -484,7 +484,7 @@ const verifyEmptyPageElements = () => {
 
     cy.verifyElement({
         element: homePageElements.CRASH_STATISTICS.TOTAL_CRASHES_TREND_VALUE,
-        elementText: "NA",
+        elementText: "0",
     });
 
     cy.verifyElement({
@@ -498,7 +498,7 @@ const verifyEmptyPageElements = () => {
 
     cy.verifyElement({
         element: homePageElements.CRASH_STATISTICS.UNIQUE_CRASHES_TREND_VALUE,
-        elementText: "NA",
+        elementText: "0",
     });
 
     cy.verifyElement({
@@ -512,7 +512,7 @@ const verifyEmptyPageElements = () => {
 
     cy.verifyElement({
         element: homePageElements.CRASH_STATISTICS.CRASH_FREE_USERS_NUMBER,
-        elementText: "100.00%",
+        elementText: "NA",
     });
 
     cy.verifyElement({
@@ -521,12 +521,12 @@ const verifyEmptyPageElements = () => {
 
     cy.verifyElement({
         element: homePageElements.CRASH_STATISTICS.CRASH_FREE_USERS_TREND_VALUE,
-        elementText: "0.0%",
+        elementText: "NA",
     });
 
     cy.verifyElement({
         element: homePageElements.CRASH_STATISTICS.CRASH_FREE_SESSIONS_NUMBER,
-        elementText: "100.00%",
+        elementText: "NA",
     });
 
     cy.verifyElement({
@@ -535,7 +535,7 @@ const verifyEmptyPageElements = () => {
 
     cy.verifyElement({
         element: homePageElements.CRASH_STATISTICS.CRASH_FREE_SESSIONS_TREND_VALUE,
-        elementText: "0.0%",
+        elementText: "NA",
     });
 };
 
@@ -806,4 +806,4 @@ const verifyFullDataPageElements = () => {
 module.exports = {
     verifyEmptyPageElements,
     verifyFullDataPageElements
-};
+};