Skip to content

Commit ffb9230

Browse files
authored
Merge branch 'master' into ar2rsawseen/master2
2 parents 8c417c0 + 2e0dd22 commit ffb9230

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
## Version 25.03.XX
2-
32
Fixes:
43
- [crashes] Derive crash name from crash stracktrace for drill event
54
- [data-manager] Fix frontend component attribute name
5+
- [star-rating] Fix rating not appearing when app version contains space ' '
66

77
## Version 25.03.7
88
Enterprise Features:

plugins/star-rating/api/api.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -904,7 +904,7 @@ function uploadFile(myfile, id, callback) {
904904
"contact_me": currEvent.segmentation.contactMe,
905905
"rating": currEvent.segmentation.rating,
906906
"platform": currEvent.segmentation.platform,
907-
"app_version": currEvent.segmentation.app_version,
907+
"app_version": currEvent.segmentation.app_version.trim(),
908908
"widget_id": currEvent.segmentation.widget_id
909909
}, function(err) {
910910
if (err) {

plugins/star-rating/frontend/public/javascripts/countly.views.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -622,7 +622,7 @@
622622
regexString += this.activeFilter.platform.toString().toUpperCase() + '(\\*\\*)';
623623
}
624624
if (this.activeFilter.version === '') {
625-
regexString += '(\\w+)(\\S*)(\\w*)(\\*\\*)[1-5]';
625+
regexString += '(.*)(\\*\\*)[1-5]';
626626
}
627627
else {
628628
regexString += this.activeFilter.version.toString() + '(\\*\\*)[1-5]';
@@ -1281,7 +1281,7 @@
12811281
regexString += this.activeFilter.platform.toString().toUpperCase() + '(\\*\\*)';
12821282
}
12831283
if (this.activeFilter.version === '') {
1284-
regexString += '(\\w+)(\\S*)(\\w*)(\\*\\*)[1-5]';
1284+
regexString += '(.*)(\\*\\*)[1-5]';
12851285
}
12861286
else {
12871287
regexString += this.activeFilter.version.toString() + '(\\*\\*)[1-5]';

0 commit comments

Comments
 (0)