Add Vision Support (#461)

Author: MikeAlhayek

.github/copilot-instructions.md

@@ -104,6 +104,7 @@ dotnet run
 * When an object initializer spans multiple lines, place each property assignment on its own line.
 * Format conditional (`?:`) operators across multiple lines with the condition, `?`, and `:` each on their own properly indented lines.
 * Always keep exactly one trailing newline at the end of each file.
+* In `.cshtml` files, never introduce stray carriage returns (`^M`) or CRCRLF line endings; keep view files normalized so they do not render with artificial blank lines.
 
 #### `#pragma` Rules
 
@@ -159,6 +160,7 @@ dotnet run
 #### JavaScript in `.cshtml`
 
 * Ensure proper indentation for all JavaScript inside `.cshtml` files.
+* When editing `.cshtml` files, preserve normalized line endings and remove any stray `^M`/CRCRLF formatting damage instead of leaving it in place.
 
 #### Architecture & Design
 
@@ -397,6 +399,7 @@ If CloudSmith is inaccessible, only asset builds and code analysis are possible.
 - **Authorization handlers**: Do not constructor-inject `IAuthorizationService` into an `AuthorizationHandler`. Resolve and cache it lazily inside the handler because the authorization pipeline can otherwise create circular dependencies.
 - **Collection handling**: Do not call `.ToList()` or `.ToArray()` unless a concrete snapshot is truly required for correctness or lifetime safety. Prefer consuming `IEnumerable<T>` directly when you only need to iterate.
 - **Localization extraction**: When using `ILocalizer`, the property/variable must be named `S`, and localized strings must use the literal pattern `S["This is a localized string"]`. Do not use variables inside the brackets because extraction tooling looks specifically for `S["..."]`.
+- **Select lists from enums**: Do not build Orchard `SelectListItem` collections by iterating enums with `Enum.GetValues(...)` and piping `ToString()` into the text. Define each item explicitly so the title uses `S["..."]` for extraction and multi-word labels can use the correct spacing.
 - **Settings UI casing**: Use sentence case for settings labels, hints, and warning headings. Keep placement tab/card/column names and admin menu labels in title case.
 - **Catalog entry handlers**: When a feature must react to create, update, or delete operations for catalog-backed models, prefer `CatalogEntryHandlerBase<T>` registered as `ICatalogEntryHandler<T>` and route write operations through the matching catalog manager so the handler events actually run. Do not rely on raw store writes alone when handler lifecycle behavior is required.
 - **Deferred third-party work**: When a catalog handler must call indexing systems, external APIs, or other third-party/background-style services, follow the deferred task pattern used by `ChatInteractionHandler` and `AIMemoryEntryHandler`: capture the affected models/IDs in the scoped handler and schedule the work with `ShellScope.AddDeferredTask(...)` so the external work runs later instead of inline during the catalog event.

Directory.Packages.props

@@ -3,7 +3,7 @@
     <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
     <CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
     <OrchardCoreVersion>[3.0.0-preview-19022, )</OrchardCoreVersion>
-    <CrestAppsCoreVersion>1.0.0-preview.108</CrestAppsCoreVersion>
+    <CrestAppsCoreVersion>1.0.0-preview.112</CrestAppsCoreVersion>
     <ModelContextProtocolVersion>1.3.0</ModelContextProtocolVersion>
   </PropertyGroup>
   <ItemGroup>
@@ -131,7 +131,7 @@
   <ItemGroup>
     <!-- Testing Packages -->
     <PackageVersion Include="Moq" Version="4.20.72" />
-    <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.5.1" />
+    <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.6.0" />
     <PackageVersion Include="xunit.v3" Version="3.2.2" />
     <PackageVersion Include="xunit.analyzers" Version="1.27.0" />
     <PackageVersion Include="xunit.runner.visualstudio" Version="3.1.5" />
@@ -159,4 +159,4 @@
     <PackageVersion Include="ModelContextProtocol.AspNetCore" Version="$(ModelContextProtocolVersion)" />
     <PackageVersion Include="ModelContextProtocol.Core" Version="$(ModelContextProtocolVersion)" />
   </ItemGroup>
-</Project>
+</Project>

src/Core/CrestApps.OrchardCore.AI.Chat.Core/Hubs/AIChatHub.cs

@@ -333,8 +333,8 @@ protected override async Task ProcessGeneratedPromptAsync(
         }, cancellationToken);
 
         var deploymentManager = services.GetRequiredService<IAIDeploymentManager>();
-        var chatDeployment = await deploymentManager.ResolveOrDefaultAsync(AIDeploymentType.Chat, deploymentName: completionContext.ChatDeploymentName, cancellationToken: cancellationToken)
-        ?? throw new InvalidOperationException("Unable to resolve a chat deployment for the profile.");
+        var chatDeployment = await deploymentManager.ResolveOrDefaultAsync(AIDeploymentPurpose.Chat, deploymentName: completionContext.ChatDeploymentName, cancellationToken: cancellationToken)
+            ?? throw new InvalidOperationException("Unable to resolve a chat deployment for the profile.");
 
         using var builder = ZString.CreateStringBuilder();
         var references = new Dictionary<string, AICompletionReference>();

src/Core/CrestApps.OrchardCore.AI.Core/Handlers/AIDeploymentHandler.cs

@@ -70,9 +70,9 @@ public override async Task ValidatingAsync(ValidatingContext<AIDeployment> conte
             context.Result.Fail(new ValidationResult(S["Model name is required."], [nameof(AIDeployment.ModelName)]));
         }
 
-        if (!context.Model.Type.IsValidSelection())
+        if (!context.Model.Purpose.IsValidSelection())
         {
-            context.Result.Fail(new ValidationResult(S["The deployment type '{0}' is not valid.", context.Model.Type], [nameof(AIDeployment.Type)]));
+            context.Result.Fail(new ValidationResult(S["The deployment purpose '{0}' is not valid.", context.Model.Purpose], [nameof(AIDeployment.Purpose)]));
         }
 
         var requiresConnection = !HasContainedConnection(context.Model.ClientName);
@@ -160,9 +160,10 @@ private static Task PopulateAsync(AIDeployment deployment, JsonNode data)
 
         PopulateContainedConnectionAliases(deployment, data);
 
-        if (TryGetDeploymentType(data[nameof(AIDeployment.Type)], out var type))
+        if (TryGetDeploymentPurpose(data[nameof(AIDeployment.Purpose)], out var purpose) ||
+            TryGetDeploymentPurpose(data["Type"], out purpose))
         {
-            deployment.Type = type;
+            deployment.Purpose = purpose;
         }
 
         var properties = data[nameof(AIDeployment.Properties)]?.AsObject();
@@ -200,38 +201,38 @@ private static void CopyStringProperty(JsonNode data, AIDeployment deployment, s
         deployment.Properties[propertyName] = propertyValue;
     }
 
-    private static bool TryGetDeploymentType(JsonNode typeNode, out AIDeploymentType type)
+    private static bool TryGetDeploymentPurpose(JsonNode purposeNode, out AIDeploymentPurpose purpose)
     {
-        type = AIDeploymentType.None;
+        purpose = AIDeploymentPurpose.None;
 
-        if (typeNode is null)
+        if (purposeNode is null)
         {
             return false;
         }
 
-        if (typeNode is JsonArray array)
+        if (purposeNode is JsonArray array)
         {
             foreach (var item in array)
             {
                 if (item is null ||
-                    !Enum.TryParse<AIDeploymentType>(item.GetValue<string>(), ignoreCase: true, out var parsedType) ||
-                        parsedType == AIDeploymentType.None)
+                    !Enum.TryParse<AIDeploymentPurpose>(item.GetValue<string>(), ignoreCase: true, out var parsedPurpose) ||
+                        parsedPurpose == AIDeploymentPurpose.None)
                 {
-                    type = AIDeploymentType.None;
+                    purpose = AIDeploymentPurpose.None;
                     return false;
                 }
 
-                type |= parsedType;
+                purpose |= parsedPurpose;
             }
 
-            return type.IsValidSelection();
+            return purpose.IsValidSelection();
         }
 
-        var typeValue = typeNode.GetValue<string>();
+        var purposeValue = purposeNode.GetValue<string>();
 
-        return !string.IsNullOrEmpty(typeValue) &&
-            Enum.TryParse(typeValue, ignoreCase: true, out type) &&
-                type.IsValidSelection();
+        return !string.IsNullOrEmpty(purposeValue) &&
+            Enum.TryParse(purposeValue, ignoreCase: true, out purpose) &&
+                purpose.IsValidSelection();
     }
 
     private bool HasContainedConnection(string clientName)

src/Core/CrestApps.OrchardCore.AI.Core/Services/DataSourceIndexingService.cs

@@ -871,7 +871,7 @@ private async Task<AIDeployment> ResolveEmbeddingDeploymentAsync(
 
         var configuredDeployment = await _deploymentManager.FindByNameAsync(embeddingDeploymentName, cancellationToken);
 
-        if (configuredDeployment?.SupportsType(AIDeploymentType.Embedding) == true)
+        if (configuredDeployment?.SupportsPurpose(AIDeploymentPurpose.Embedding) == true)
         {
             return configuredDeployment;
         }
@@ -908,7 +908,7 @@ private async Task<AIDeployment> ResolveCanonicalEmbeddingDeploymentAsync(
             return null;
         }
 
-        var deployments = (await _deploymentManager.GetByTypeAsync(AIDeploymentType.Embedding, cancellationToken) ?? [])
+        var deployments = (await _deploymentManager.GetByPurposeAsync(AIDeploymentPurpose.Embedding, cancellationToken) ?? [])
             .Where(deployment => MatchesEmbeddingSelector(deployment, selectorCandidates))
             .ToArray();
 
@@ -986,7 +986,7 @@ private static bool MatchesEmbeddingSelector(AIDeployment deployment, HashSet<st
         ArgumentNullException.ThrowIfNull(deployment);
         ArgumentNullException.ThrowIfNull(selectorCandidates);
 
-        return deployment.SupportsType(AIDeploymentType.Embedding) &&
+        return deployment.SupportsPurpose(AIDeploymentPurpose.Embedding) &&
             (selectorCandidates.Contains(deployment.Name) ||
                 selectorCandidates.Contains(deployment.ModelName));
     }

src/Core/CrestApps.OrchardCore.AI.Core/Services/DefaultSpeechVoicePresenter.cs

@@ -50,7 +50,7 @@ public async Task<IEnumerable<SelectListItem>> GetVoiceMenuItemsAsync(string dep
         {
             var deployment = !string.IsNullOrEmpty(deploymentName)
             ? await _deploymentManager.FindByNameAsync(deploymentName)
-            : await _deploymentManager.ResolveOrDefaultAsync(AIDeploymentType.TextToSpeech);
+            : await _deploymentManager.ResolveOrDefaultAsync(AIDeploymentPurpose.TextToSpeech);
 
             if (deployment == null)
             {

src/Core/CrestApps.OrchardCore.Recipes.Core/Schemas/AIDeploymentRecipeStep.cs

@@ -50,10 +50,10 @@ private static JsonSchema CreateSchema()
                 ("ApiKey", new JsonSchemaBuilder().Type(SchemaValueType.String).Description("Contained-connection API key alias for recipe imports. Supported by AzureSpeech deployments.")),
                 ("IdentityId", new JsonSchemaBuilder().Type(SchemaValueType.String).Description("Contained-connection managed identity client ID alias for recipe imports. Supported by AzureSpeech deployments.")),
                 ("Properties", containedConnectionPropertiesSchema),
-                ("Type", new JsonSchemaBuilder().AnyOf(
-                    new JsonSchemaBuilder().Type(SchemaValueType.String).Description("The deployment type, or a comma-separated flag value such as 'Chat, Utility'. Defaults to Chat when not specified."),
+                ("Purpose", new JsonSchemaBuilder().AnyOf(
+                    new JsonSchemaBuilder().Type(SchemaValueType.String).Description("The deployment purpose, or a comma-separated flag value such as 'Chat, Utility'. Defaults to Chat when not specified."),
                     new JsonSchemaBuilder().Type(SchemaValueType.Array).Items(
-                        new JsonSchemaBuilder().Type(SchemaValueType.String).Enum("Chat", "Utility", "Embedding", "Image", "SpeechToText", "TextToSpeech")).MinItems(1).UniqueItems(true).Description("The deployment types."))))
+                        new JsonSchemaBuilder().Type(SchemaValueType.String).Enum("Chat", "Utility", "Embedding", "Image", "SpeechToText", "TextToSpeech", "Vision")).MinItems(1).UniqueItems(true).Description("The deployment purposes."))))
             .Required("Name")
             .AdditionalProperties(true);
 

src/Core/CrestApps.OrchardCore.Recipes.Core/Schemas/SiteSettings/DefaultAIDeploymentSettingsSchema.cs

@@ -24,6 +24,7 @@ protected override JsonSchemaBuilder BuildSchemaCore()
                 ("DefaultUtilityDeploymentName", new JsonSchemaBuilder().Type(SchemaValueType.String).Description("The technical name of the default utility deployment.")),
                 ("DefaultEmbeddingDeploymentName", new JsonSchemaBuilder().Type(SchemaValueType.String).Description("The technical name of the default embedding deployment.")),
                 ("DefaultImageDeploymentName", new JsonSchemaBuilder().Type(SchemaValueType.String).Description("The technical name of the default image generation deployment.")),
+                ("DefaultVisionDeploymentName", new JsonSchemaBuilder().Type(SchemaValueType.String).Description("The technical name of the default vision deployment.")),
                 ("DefaultSpeechToTextDeploymentName", new JsonSchemaBuilder().Type(SchemaValueType.String).Description("The technical name of the default speech-to-text deployment.")),
                 ("DefaultTextToSpeechDeploymentName", new JsonSchemaBuilder().Type(SchemaValueType.String).Description("The technical name of the default text-to-speech deployment.")),
                 ("DefaultTextToSpeechVoiceId", new JsonSchemaBuilder().Type(SchemaValueType.String).Description("The voice identifier to use for text-to-speech.")))

src/CrestApps.Docs/docs/ai/chat-interactions.md

@@ -31,6 +31,7 @@ This module provides ad-hoc AI chat interactions with configurable parameters, e
 - User memory — persist private, non-sensitive preferences and durable background details for authenticated users
 - Chat mode — configurable voice interaction modes (Text Only, Audio Input, Conversation) for speech-to-text dictation and two-way voice chat
 - Prompt-template composition — add multiple reusable prompt templates from a searchable picker and provide per-template JSON parameters
+- Vision-aware knowledge uploads — the Knowledge tab updates its supported formats immediately when you switch the chat deployment, so image-capable models expose image upload extensions without reloading the page
 
 ## Getting Started
 
@@ -47,6 +48,8 @@ When a response cites uploaded or indexed content, the interaction UI renders `[
 
 The admin **Chat Interactions** list includes integrated search, multi-select, and bulk actions through the shared list management resource used across CrestApps admin catalogs.
 
+When the **AI Documents** feature is enabled, the **Knowledge** tab shows the current supported upload formats directly under the file picker. That list refreshes immediately when you change the selected chat deployment, including the **Default** option when the tenant default chat deployment supports vision.
+
 ## Orchestration
 
 Each chat interaction session is bound to an orchestrator that manages the execution pipeline. The orchestrator handles:
@@ -185,4 +188,3 @@ To enable image generation, create an `AIDeployment` record with type `Image` fo
   }
 }
 ```
-

src/CrestApps.Docs/docs/ai/chat.md

@@ -142,6 +142,8 @@ If a profile allows session documents, the chat UI keeps restored widget session
 
 The admin and frontend chat widgets restore their saved toggle and panel positions before the chat app finishes initializing.
 
+The admin session chat now shows the same compact **Supported formats** note above the input attachment bar that the widgets already expose, so users can see the exact upload extensions allowed for the current profile and vision capability.
+
 By default, session-document uploads are stored on the local file system through the shared AI Documents storage pipeline. If you want widget uploads stored in Azure Blob Storage instead, enable `CrestApps.OrchardCore.AI.Documents.Azure` and configure it as described in [AI Documents - Azure Blob Storage](./documents/azure-blob-storage.md).
 
 ### Citations and references