fix(fcs): add IOM limit validation, improve risks examples, and enhance error handling - #48
Open
eeran-cs wants to merge 2 commits into
Open
Conversation
- Add limit validation to IOM list command (max 100 items) - Improve risks list command examples with correct severity format and filtering options - Enhance error handling with filter hints for 400 responses - Add legacy operation name keys for backward compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--limitcap of 100 with a clear error message when exceeded (the API returns an error for larger values)--filterexamples — severity values must be uppercase (HIGH,CRITICAL), and thecloud_providerFQL field is unreliable so examples now show--grepandjqalternatives; fix sort syntax fromfield.desctofield|descfilterHintsmap soHandleAPIErrorsurfaces known filter field names on 400 responses; add human-readable keys tofeatureRequirementsfor the compliance 404 caseTest plan
falcon fcs iom list --limit 101returns a clear errorfalcon fcs risks list --filter "severity:'HIGH'"works;--filter "severity:'High'"documents the uppercase requirementfalcon fcs risks list --sort "severity|desc"worksHandleAPIErroron a 400 fromContainerCombinedincludes the filter field hint