some todos

Author: aykut-bozkurt

README.md

@@ -423,6 +423,7 @@ There is currently only one GUC parameter to enable/disable the `pg_parquet`:
 | `time`            | INT64                     | TIME_MICROS      |
 | `timetz`(3)       | INT64                     | TIME_MICROS      |
 | `geometry`(4)     | BYTE_ARRAY                |                  |
+| `geography`(4)    | BYTE_ARRAY                |                  |
 
 ### Nested Types
 | PostgreSQL Type   | Parquet Physical Type     | Logical Type     |
@@ -440,7 +441,7 @@ There is currently only one GUC parameter to enable/disable the `pg_parquet`:
 >    * `numeric` is allowed by Postgres. (precision and scale not specified). These are represented by a default precision (38) and scale (9) instead of writing them as string. You get runtime error if your table tries to read or write a numeric value which is not allowed by the default precision and scale (29 integral digits before decimal point, 9 digits after decimal point).
 > - (2) The `date` type is represented according to `Unix epoch` when writing to Parquet files. It is converted back according to `PostgreSQL epoch` when reading from Parquet files.
 > - (3) The `timestamptz` and `timetz` types are adjusted to `UTC` when writing to Parquet files. They are converted back with `UTC` timezone when reading from Parquet files.
-> - (4) The `geometry` type is represented as `BYTE_ARRAY` encoded as `WKB`, specified by [geoparquet spec](https://geoparquet.org/releases/v1.1.0/), when `postgis` extension is created. Otherwise, it is represented as `BYTE_ARRAY` with `STRING` logical type.
+> - (4) The `geometry` and `geography` type is represented as `BYTE_ARRAY` encoded as `WKB`, specified by [geoparquet spec](https://geoparquet.org/releases/v1.1.0/), when `postgis` extension is created. Otherwise, it is represented as `BYTE_ARRAY` with `STRING` logical type. Orientation and edges metadata are written when `postgis_sfcgal` extension is created.
 > - (5) `crunchy_map` is dependent on functionality provided by [Crunchy Bridge](https://www.crunchydata.com/products/crunchy-bridge). The `crunchy_map` type is represented as `GROUP` with `MAP` logical type when `crunchy_map` extension is created. Otherwise, it is represented as `BYTE_ARRAY` with `STRING` logical type.
 
 > [!WARNING]

src/parquet_copy_hook/copy_utils.rs

@@ -24,7 +24,7 @@ use crate::{
         parquet_writer::{DEFAULT_ROW_GROUP_SIZE, DEFAULT_ROW_GROUP_SIZE_BYTES},
         uri_utils::ParsedUriInfo,
     },
-    pgrx_utils::extension_exists,
+    pgrx_utils::is_extension_created,
 };
 
 use self::field_ids::FieldIds;
@@ -483,12 +483,12 @@ fn is_copy_parquet_stmt(p_stmt: &PgBox<PlannedStmt>, copy_from: bool) -> bool {
     // this is why we check them after the uri checks
 
     // crunchy_query_engine should not be created
-    if extension_exists("crunchy_query_engine") {
+    if is_extension_created("crunchy_query_engine") {
         return false;
     }
 
     // pg_parquet should be created
-    if !extension_exists("pg_parquet") {
+    if !is_extension_created("pg_parquet") {
         ereport!(
             PgLogLevel::WARNING,
             PgSqlErrorCode::ERRCODE_WARNING,

src/pgrx_tests/common.rs

@@ -358,7 +358,7 @@ pub(crate) fn timetz_array_to_utc_time_array(
     )
 }
 
-pub(crate) fn extension_exists(extension_name: &str) -> bool {
+pub(crate) fn is_extension_available(extension_name: &str) -> bool {
     let quoted_extension = spi::quote_literal(extension_name);
     let query =
         format!("select count(*) = 1 from pg_available_extensions where name = {quoted_extension}");
@@ -375,7 +375,7 @@ pub(crate) fn write_record_batch_to_parquet(schema: SchemaRef, record_batch: Rec
 }
 
 pub(crate) fn create_crunchy_map_type(key_type: &str, val_type: &str) -> String {
-    assert!(extension_exists("crunchy_map"));
+    assert!(is_extension_available("crunchy_map"));
 
     let command = format!("SELECT crunchy_map.create('{key_type}','{val_type}')::text;",);
     Spi::get_one(&command).unwrap().unwrap()

src/pgrx_tests/copy_from_coerce.rs

@@ -5,7 +5,7 @@ mod tests {
     use std::vec;
 
     use crate::pgrx_tests::common::{
-        extension_exists, write_record_batch_to_parquet, LOCAL_TEST_FILE_PATH,
+        is_extension_available, write_record_batch_to_parquet, LOCAL_TEST_FILE_PATH,
     };
     use crate::type_compat::pg_arrow_type_conversions::{
         date_to_i32, time_to_i64, timestamp_to_i64, timestamptz_to_i64, timetz_to_i64,
@@ -886,7 +886,7 @@ mod tests {
     #[pg_test]
     fn test_coerce_map_types() {
         // Skip the test if crunchy_map extension is not available
-        if !extension_exists("crunchy_map") {
+        if !is_extension_available("crunchy_map") {
             return;
         }
 
@@ -946,7 +946,7 @@ mod tests {
     #[pg_test]
     fn test_coerce_list_of_map() {
         // Skip the test if crunchy_map extension is not available
-        if !extension_exists("crunchy_map") {
+        if !is_extension_available("crunchy_map") {
             return;
         }
 

src/pgrx_tests/copy_options.rs

@@ -6,8 +6,8 @@ mod tests {
 
     use crate::{
         pgrx_tests::common::{
-            create_crunchy_map_type, extension_exists, CopyOptionValue, FileCleanup, TestTable,
-            LOCAL_TEST_FILE_PATH,
+            create_crunchy_map_type, is_extension_available, CopyOptionValue, FileCleanup,
+            TestTable, LOCAL_TEST_FILE_PATH,
         },
         PgParquetCompression,
     };
@@ -799,7 +799,7 @@ mod tests {
     #[pg_test]
     fn test_auto_field_ids_with_map() {
         // Skip the test if crunchy_map extension is not available
-        if !extension_exists("crunchy_map") {
+        if !is_extension_available("crunchy_map") {
             return;
         }
 
@@ -891,7 +891,7 @@ mod tests {
     #[pg_test]
     fn test_explicit_field_ids_with_map() {
         // Skip the test if crunchy_map extension is not available
-        if !extension_exists("crunchy_map") {
+        if !is_extension_available("crunchy_map") {
             return;
         }