Skip to content

Commit 503d11d

Browse files
authored
Rename reserve_pool to reserve_pool_size (#30)
* fix: fix pgbouncer_server view missing column * chore: update changelog * fix: fix pgbouncer_dns_zones view missing column * fix: change column name reserve_pool to reserve_pool_size for show databases * fix reserve_pool_size datatype in users
1 parent 95c9763 commit 503d11d

File tree

5 files changed

+395
-15
lines changed

5 files changed

+395
-15
lines changed

CHANGELOG

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
v1.4.0
2+
-- Update to support column change in databases from reserve_pool to reserve_pool_size in pgBouncer 1.24
3+
-- Set proper data type for reserve_pool_size in users
4+
5+
16
v1.3.0
27
-- Update to support pgBouncer 1.24
38
-- Improved support for newer columns that don't exist in older versions of pgBouncer

pgbouncer_fdw.control

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
default_version = '1.3.0'
1+
default_version = '1.4.0'
22
comment = 'Extension for querying PgBouncer stats from normal SQL views & running pgbouncer commands from normal SQL functions'
33
requires = dblink
44
relocatable = false

sql/functions/pgbouncer_fdw_functions.sql

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,7 @@ CREATE FUNCTION @[email protected]_databases_func() RETURNS TABLE
422422
, force_user text
423423
, pool_size int
424424
, min_pool_size int
425-
, reserve_pool int
425+
, reserve_pool_size int
426426
, server_lifetime int
427427
, pool_mode text
428428
, load_balance_hosts int
@@ -464,7 +464,7 @@ LOOP BEGIN
464464
, x.force_user
465465
, x.pool_size
466466
, x.min_pool_size
467-
, x.reserve_pool
467+
, x.reserve_pool_size
468468
, x.server_lifetime
469469
, x.pool_mode
470470
, x.load_balance_hosts
@@ -483,7 +483,7 @@ LOOP BEGIN
483483
, force_user text
484484
, pool_size int
485485
, min_pool_size int
486-
, reserve_pool int
486+
, reserve_pool_size int
487487
, server_lifetime int
488488
, pool_mode text
489489
, load_balance_hosts int
@@ -504,7 +504,7 @@ LOOP BEGIN
504504
, x.force_user
505505
, x.pool_size
506506
, x.min_pool_size
507-
, x.reserve_pool
507+
, x.reserve_pool AS reserve_pool_size
508508
, x.server_lifetime
509509
, x.pool_mode
510510
, 0 AS load_balance_hosts
@@ -541,7 +541,7 @@ LOOP BEGIN
541541
, x.force_user
542542
, x.pool_size
543543
, x.min_pool_size
544-
, x.reserve_pool
544+
, x.reserve_pool AS reserve_pool_size
545545
, 0 AS server_lifetime
546546
, x.pool_mode
547547
, 0 AS load_balance_hosts
@@ -589,7 +589,6 @@ END LOOP;
589589
END
590590
$$;
591591

592-
593592
/*
594593
* pgbouncer_dns_hosts_func
595594
*/
@@ -1837,7 +1836,7 @@ CREATE FUNCTION @[email protected]_users_func() RETURNS TABLE
18371836
pgbouncer_target_host text
18381837
, name text
18391838
, pool_size int
1840-
, reserve_pool_size text
1839+
, reserve_pool_size int
18411840
, pool_mode text
18421841
, max_user_connections int
18431842
, current_connections int
@@ -1880,7 +1879,7 @@ LOOP BEGIN
18801879
(
18811880
name text
18821881
, pool_size int
1883-
, reserve_pool_size text
1882+
, reserve_pool_size int
18841883
, pool_mode text
18851884
, max_user_connections int
18861885
, current_connections int
@@ -1892,7 +1891,7 @@ LOOP BEGIN
18921891
v_row.target_host AS pgbouncer_target_host
18931892
, x.name
18941893
, x.pool_size
1895-
, '' AS reserve_pool_size
1894+
, 0 AS reserve_pool_size
18961895
, x.pool_mode
18971896
, x.max_user_connections
18981897
, x.current_connections
@@ -1911,7 +1910,7 @@ LOOP BEGIN
19111910
v_row.target_host AS pgbouncer_target_host
19121911
, x.name
19131912
, 0 AS pool_size
1914-
, '' AS reserve_pool_size
1913+
, 0 AS reserve_pool_size
19151914
, x.pool_mode
19161915
, 0 AS max_user_connections
19171916
, 0 AS current_connections

sql/views/pgbouncer_fdw_views.sql

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ CREATE VIEW @[email protected]_config AS
4040
, changeable
4141
FROM @[email protected]_config_func();
4242

43-
4443
CREATE VIEW @[email protected]_databases AS
4544
SELECT pgbouncer_target_host
4645
, name
@@ -50,7 +49,7 @@ CREATE VIEW @[email protected]_databases AS
5049
, force_user
5150
, pool_size
5251
, min_pool_size
53-
, reserve_pool
52+
, reserve_pool_size
5453
, server_lifetime
5554
, pool_mode
5655
, load_balance_hosts
@@ -62,7 +61,6 @@ CREATE VIEW @[email protected]_databases AS
6261
, disabled
6362
FROM @[email protected]_databases_func();
6463

65-
6664
CREATE VIEW @[email protected]_dns_hosts AS
6765
SELECT pgbouncer_target_host
6866
, hostname
@@ -203,4 +201,3 @@ CREATE VIEW @[email protected]_users AS
203201
, max_user_client_connections
204202
, current_client_connections
205203
FROM @[email protected]_users_func();
206-

0 commit comments

Comments
 (0)