Switch AddConditionArchive to the new serialization system

Author: Crypto137

src/MHServerEmu.Games/Events/EventManager.cs

@@ -278,7 +278,7 @@ private void OnStartTravel(PlayerConnection playerConnection, PrototypeId powerI
                     conditionArchive.Condition.CreatorPowerIndex = 0;
 
                     playerConnection.SendMessage(NetMessageAddCondition.CreateBuilder()
-                        .SetArchiveData(conditionArchive.Serialize())
+                        .SetArchiveData(conditionArchive.SerializeToByteString())
                         .Build());
 
                     playerConnection.SendMessage(NetMessagePowerCollectionAssignPower.CreateBuilder()
@@ -305,7 +305,7 @@ private void OnStartTravel(PlayerConnection playerConnection, PrototypeId powerI
                     conditionArchive = new(avatarEntityId, 667, conditionSerializationFlags, powerId, TimeSpan.Zero);
                     conditionArchive.Condition.CreatorPowerIndex = 0;
                     playerConnection.SendMessage(NetMessageAddCondition.CreateBuilder()
-                        .SetArchiveData(conditionArchive.Serialize())
+                        .SetArchiveData(conditionArchive.SerializeToByteString())
                         .Build());
                     break;
             }
@@ -462,7 +462,7 @@ private void OnDiamondFormActivate(PlayerConnection playerConnection)
             conditionArchive.Condition.CreatorPowerIndex = 0;
 
             playerConnection.SendMessage(NetMessageAddCondition.CreateBuilder()
-                 .SetArchiveData(conditionArchive.Serialize())
+                 .SetArchiveData(conditionArchive.SerializeToByteString())
                  .Build());
         }
 
@@ -491,7 +491,7 @@ private void OnStartMagikUltimate(PlayerConnection playerConnection, NetStructPo
             conditionArchive.Condition.CreatorPowerIndex = 0;
 
             playerConnection.SendMessage(NetMessageAddCondition.CreateBuilder()
-                .SetArchiveData(conditionArchive.Serialize())
+                .SetArchiveData(conditionArchive.SerializeToByteString())
                 .Build());
 
             WorldEntity arenaEntity = _game.EntityManager.CreateWorldEntityEmpty(

src/MHServerEmu.Games/Powers/AddConditionArchive.cs

@@ -1,28 +1,33 @@
 using System.Text;
 using Google.ProtocolBuffers;
+using MHServerEmu.Core.Serialization;
+using MHServerEmu.Games.Common;
 using MHServerEmu.Games.GameData;
 using MHServerEmu.Games.Network;
 
 namespace MHServerEmu.Games.Powers
 {
     public class AddConditionArchive
     {
+        private ulong _entityId;
+
         public AOINetworkPolicyValues ReplicationPolicy { get; set; }
-        public ulong EntityId { get; set; }
+        public ulong EntityId { get => _entityId; set => _entityId = value; }
         public Condition Condition { get; set; }
 
+        public AddConditionArchive() { }
+
         public AddConditionArchive(ByteString data)
         {
-            CodedInputStream stream = CodedInputStream.CreateInstance(data.ToByteArray());
-
-            ReplicationPolicy = (AOINetworkPolicyValues)stream.ReadRawVarint32();
-            EntityId = stream.ReadRawVarint64();
-            Condition = new();
-            Condition.Decode(stream);
+            using (Archive archive = new(ArchiveSerializeType.Replication, data.ToByteArray()))
+            {
+                ReplicationPolicy = (AOINetworkPolicyValues)archive.ReplicationPolicy;
+                Serializer.Transfer(archive, ref _entityId);
+                Condition = new();
+                Condition.Serialize(archive, null);
+            }
         }
 
-        public AddConditionArchive() { }
-
         public AddConditionArchive(ulong entityId, ulong id, ConditionSerializationFlags serializationFlags, PrototypeId prototypeId, TimeSpan startTime)
         {
             ReplicationPolicy = AOINetworkPolicyValues.DefaultPolicy;
@@ -37,27 +42,24 @@ public AddConditionArchive(ulong entityId, ulong id, ConditionSerializationFlags
             };
         }
 
-        public ByteString Serialize()
+        public ByteString SerializeToByteString()
         {
-            using (MemoryStream ms = new())
+            using (Archive archive = new(ArchiveSerializeType.Replication, (ulong)ReplicationPolicy))
             {
-                CodedOutputStream cos = CodedOutputStream.CreateInstance(ms);
-
-                cos.WriteRawVarint32((uint)ReplicationPolicy);
-                cos.WriteRawVarint64(EntityId);
-                Condition.Encode(cos);
+                ulong entityId = EntityId;
+                archive.Transfer(ref entityId);
+                Condition.Serialize(archive, null);
 
-                cos.Flush();
-                return ByteString.CopyFrom(ms.ToArray());
+                return ByteString.CopyFrom(archive.AccessAutoBuffer().ToArray());
             }
         }
 
         public override string ToString()
         {
             StringBuilder sb = new();
-            sb.AppendLine($"ReplicationPolicy: {ReplicationPolicy}");
-            sb.AppendLine($"EntityId: {EntityId}");
-            sb.AppendLine($"Condition: {Condition}");
+            sb.AppendLine($"{nameof(ReplicationPolicy)}: {ReplicationPolicy}");
+            sb.AppendLine($"{nameof(EntityId)}: {EntityId}");
+            sb.AppendLine($"{nameof(Condition)}: {Condition}");
 
             return sb.ToString();
         }

src/MHServerEmu.Games/Powers/Condition.cs

@@ -142,6 +142,8 @@ public bool Serialize(Archive archive, WorldEntity owner)
                 if (_serializationFlags.HasFlag(ConditionSerializationFlags.HasUpdateInterval))
                     success &= Serializer.Transfer(archive, ref _updateIntervalMS);
 
+                success &= Serializer.Transfer(archive, ref _properties);
+
                 if (_serializationFlags.HasFlag(ConditionSerializationFlags.HasCancelOnFlags))
                 {
                     uint cancelOnFlags = (uint)_cancelOnFlags;