Skip to content

Commit a9d0018

Browse files
committed
Deal with Maven Flatten plugin shenanigans
1 parent e84000a commit a9d0018

File tree

5 files changed

+10
-153
lines changed

5 files changed

+10
-153
lines changed

TODO.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ developers can see and perhaps give suggestions about. Anyone is welcome to comp
8383
and technical details that most developers don't have to be concerned about. We should make a guide on the wiki with
8484
screenshots and a general overview of all the features which makes it much easier for developers to get started.
8585

86-
* **[Mavne]** `[ERROR] MavenInvocationException: Error when invoking Maven, consult the invoker log file ...` when
87-
building the project. The log file simply says the dependencies couldn't be resolved? Seems to be related to Javadoc goal.
88-
Also `[ERROR] Error fetching link: XSeries/<project>/target/apidocs. Ignored it.` might be related to the previous error.
86+
* **[Maven]** `[ERROR] MavenInvocationException: Error when invoking Maven, consult the invoker log file ...` when
87+
building the project. The log file simply says the dependencies couldn't be resolved? Seems to be related to Javadoc
88+
goal. Also, `[ERROR] Error fetching link: XSeries/<project>/target/apidocs. Ignored it.` might be related to
89+
the previous error.

core/.flattened-pom.xml

Lines changed: 0 additions & 149 deletions
This file was deleted.

core/dependency-reduced-pom.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
<modelVersion>4.0.0</modelVersion>
44
<groupId>com.github.cryptomorin</groupId>
55
<artifactId>XSeries</artifactId>
6-
<version>13.0.0</version>
6+
<name>XSeries</name>
7+
<version>13.1.0</version>
78
<description>A set of utilities for Minecraft plugins</description>
89
<url>https://www.spigotmc.org/threads/378136/XSeries/</url>
910
<issueManagement>

core/pom.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,9 @@
3131
<version>${revision}</version>
3232
</parent>
3333

34+
<!-- Maven Flatten Plugin doesn't inherit this tag specifically. -->
35+
<!-- https://github.com/mojohaus/flatten-maven-plugin/issues/76 -->
36+
<name>XSeries</name>
3437
<artifactId>XSeries</artifactId>
3538

3639
<properties>

pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -395,6 +395,7 @@
395395
<configuration>
396396
<keepCommentsInPom>false</keepCommentsInPom>
397397
<flattenMode>oss</flattenMode>
398+
<flattenDependencyMode>inherited</flattenDependencyMode>
398399
</configuration>
399400
<executions>
400401
<!-- enable flattening -->

0 commit comments

Comments
 (0)