v11.2.0.1

* Removed all usage of the old XReflection within XSeries code.
* Fixed a few issues with NMSExtras.
* Due to people reporting "NMS_VERSION" from getVersionInformation() returning null, it was changed to "Unknown NMS" instead.
* Fixed an issue where trying to reflect a class handle with no names provided didn't provide a proper error.

Author: CryptoMorin

pom.xml

@@ -6,7 +6,7 @@
 
     <groupId>com.github.cryptomorin</groupId>
     <artifactId>XSeries</artifactId>
-    <version>11.2.0</version>
+    <version>11.2.0.1</version>
 
     <name>XSeries</name>
     <description>A set of utilities for Minecraft plugins</description>
@@ -74,6 +74,9 @@
         <!-- https://repo.codemc.io/service/rest/repository/browse/nms/org/spigotmc/spigot/ -->
         <!-- 1.8.8-R0.1-SNAPSHOT -->
         <!-- 1.9.4-R0.1-SNAPSHOT -->
+        <!-- 1.10.2-R0.1-SNAPSHOT -->
+        <!-- 1.11.2-R0.1-SNAPSHOT -->
+        <!-- 1.12.2-R0.1-SNAPSHOT -->
         <!-- 1.13.2-R0.1-SNAPSHOT -->
         <!-- 1.14.4-R0.1-SNAPSHOT -->
         <!-- 1.15.2-R0.1-SNAPSHOT -->

src/main/java/com/cryptomorin/xseries/XWorldBorder.java

@@ -1,5 +1,6 @@
 package com.cryptomorin.xseries;
 
+import com.cryptomorin.xseries.reflection.XReflection;
 import com.cryptomorin.xseries.reflection.minecraft.MinecraftClassHandle;
 import com.cryptomorin.xseries.reflection.minecraft.MinecraftConnection;
 import com.cryptomorin.xseries.reflection.minecraft.MinecraftMapping;
@@ -307,10 +308,13 @@ public BorderBounds() {
                 try {
                     wbType = Class.forName("EnumWorldBorderAction");
                 } catch (ClassNotFoundException e) {
-                    wbType = getNMSClass("PacketPlayOutWorldBorder$EnumWorldBorderAction");
+                    wbType = XReflection.ofMinecraft().inPackage(MinecraftPackage.NMS)
+                            .named("PacketPlayOutWorldBorder$EnumWorldBorderAction").unreflect();
                 }
 
-                packetInit = lookup.findConstructor(getNMSClass("PacketPlayOutWorldBorder"), MethodType.methodType(void.class, wb.reflect(), wbType));
+                packetInit = lookup.findConstructor(XReflection.ofMinecraft().inPackage(MinecraftPackage.NMS)
+                                .named("PacketPlayOutWorldBorder").unreflect(),
+                        MethodType.methodType(void.class, wb.reflect(), wbType));
 
                 for (Object type : wbType.getEnumConstants()) {
                     if (type.toString().equals("INITIALIZE")) {

src/main/java/com/cryptomorin/xseries/messages/ActionBar.java

@@ -23,6 +23,7 @@
 
 import com.cryptomorin.xseries.reflection.XReflection;
 import com.cryptomorin.xseries.reflection.minecraft.MinecraftConnection;
+import com.cryptomorin.xseries.reflection.minecraft.MinecraftPackage;
 import com.google.common.base.Strings;
 import net.md_5.bungee.api.ChatMessageType;
 import net.md_5.bungee.api.chat.TextComponent;
@@ -94,10 +95,14 @@ public final class ActionBar {
 
         if (!USE_SPIGOT_API) {
             // Supporting 1.12+ is not necessary, the package guards are just for readability.
+            // Since these methods are old, we don't need to add Mojang mappings
             MethodHandles.Lookup lookup = MethodHandles.lookup();
-            Class<?> packetPlayOutChatClass = getNMSClass("network.protocol.game", "PacketPlayOutChat");
-            Class<?> iChatBaseComponentClass = getNMSClass("network.chat", "IChatBaseComponent");
-            Class<?> ChatSerializerClass = getNMSClass("network.chat", "IChatBaseComponent$ChatSerializer");
+            Class<?> packetPlayOutChatClass = ofMinecraft().inPackage(MinecraftPackage.NMS, "network.protocol.game")
+                    .named("PacketPlayOutChat").unreflect();
+            Class<?> iChatBaseComponentClass = ofMinecraft().inPackage(MinecraftPackage.NMS, "network.chat")
+                    .named("IChatBaseComponent").unreflect();
+            Class<?> ChatSerializerClass = ofMinecraft().inPackage(MinecraftPackage.NMS, "network.chat")
+                    .named("IChatBaseComponent$ChatSerializer").unreflect();
 
             try {
                 // JSON Message Builder
@@ -191,6 +196,7 @@ public static void sendActionBar(@Nonnull Player player, @Nullable String messag
         Objects.requireNonNull(message, "Cannot send null actionbar message");
 
         if (USE_SPIGOT_API) {
+            // noinspection deprecation
             player.spigot().sendMessage(ChatMessageType.ACTION_BAR, TextComponent.fromLegacyText(message));
             return;
         }

src/main/java/com/cryptomorin/xseries/messages/Titles.java

@@ -322,8 +322,10 @@ public static void sendTabList(@Nonnull String header, @Nonnull String footer, P
         }
 
         try {
-            Class<?> IChatBaseComponent = XReflection.getNMSClass("network.chat", "IChatBaseComponent");
-            Class<?> PacketPlayOutPlayerListHeaderFooter = XReflection.getNMSClass("network.protocol.game", "PacketPlayOutPlayerListHeaderFooter");
+            Class<?> IChatBaseComponent = ofMinecraft().inPackage(MinecraftPackage.NMS, "network.chat")
+                    .named("IChatBaseComponent").unreflect();
+            Class<?> PacketPlayOutPlayerListHeaderFooter = ofMinecraft().inPackage(MinecraftPackage.NMS, "network.protocol.game")
+                    .named("PacketPlayOutPlayerListHeaderFooter").unreflect();
 
             Method chatComponentBuilderMethod = IChatBaseComponent.getDeclaredClasses()[0].getMethod("a", String.class);
             Object tabHeader = chatComponentBuilderMethod.invoke(null, "{\"text\":\"" + header + "\"}");

src/main/java/com/cryptomorin/xseries/reflection/XReflection.java

@@ -65,7 +65,7 @@
  *     <li>{@link #relativizeSuppressedExceptions(Throwable)}: Relativize the stacktrace of exceptions that are thrown from the same location.</li>
  * </ul>
  * @author Crypto Morin
- * @version 11.2.0
+ * @version 11.2.1
  * @see com.cryptomorin.xseries.reflection.minecraft.MinecraftConnection
  * @see com.cryptomorin.xseries.reflection.minecraft.NMSExtras
  */
@@ -196,12 +196,14 @@ public static String findNMSVersionString() {
 
     /**
      * Gets the full version information of the server. Useful for including in errors.
+     * "NMS" might return "Unknown NMS", which means that they're running a Paper
+     * server that removed the CraftBukkit NMS version guard.
      *
      * @since 7.0.0
      */
     public static String getVersionInformation() {
         // Bukkit.getServer().getMinecraftVersion() is for Paper
-        return "(NMS: " + NMS_VERSION + " | " +
+        return "(NMS: " + (NMS_VERSION == null ? "Unknown NMS" : NMS_VERSION) + " | " +
                 "Parsed: " + MAJOR_NUMBER + '.' + MINOR_NUMBER + '.' + PATCH_NUMBER + " | " +
                 "Minecraft: " + Bukkit.getVersion() + " | " +
                 "Bukkit: " + Bukkit.getBukkitVersion() + ')';
@@ -501,6 +503,7 @@ public static <T, H extends ReflectiveHandle<T>> AggregateReflectiveHandle<T, H>
      */
     @ApiStatus.Experimental
     public static <T extends Throwable> T relativizeSuppressedExceptions(T ex) {
+        Objects.requireNonNull(ex, "Cannot relativize null exception");
         final StackTraceElement[] EMPTY_STACK_TRACE_ARRAY = new StackTraceElement[0];
         StackTraceElement[] mainStackTrace = ex.getStackTrace();
 
@@ -565,6 +568,7 @@ private static <T extends Throwable> void throwException(Throwable exception) th
      *   from complaining about non-terminating statements.
      */
     public static RuntimeException throwCheckedException(Throwable exception) {
+        Objects.requireNonNull(exception, "Cannot throw null exception");
         // The following commented statement is not needed because the exception was created somewhere else and the stacktrace reflects that.
         // exception.setStackTrace(Arrays.stream(exception.getStackTrace()).skip(1).toArray(StackTraceElement[]::new));
         throwException(exception);

src/main/java/com/cryptomorin/xseries/reflection/jvm/classes/DynamicClassHandle.java

@@ -61,7 +61,6 @@ public String[] reflectClassNames() {
 
         int i = 0;
         for (String className : this.classNames) {
-
             @SuppressWarnings("NonConstantStringShouldBeStringBuffer")
             String clazz;
             if (parent == null) clazz = packageName + '.' + className;
@@ -86,9 +85,11 @@ public DynamicClassHandle clone() {
 
     @Override
     public Class<?> reflect() throws ClassNotFoundException {
-        ClassNotFoundException errors = null;
+        String[] classNames = reflectClassNames();
+        if (classNames.length == 0) throw new IllegalStateException("No class name specified for " + this);
 
-        for (String className : reflectClassNames()) {
+        ClassNotFoundException errors = null;
+        for (String className : classNames) {
             try {
                 return Class.forName(className);
             } catch (ClassNotFoundException ex) {