feat(chat): handle other languages (#49)

* feat(chat): handle other languages

* feat(chat): handle other languages: lint

* fix tests

Author: sandragjacinto

src/app/api/api_v1/endpoints/user.py

@@ -1,5 +1,5 @@
-from datetime import datetime, timedelta
 import uuid
+from datetime import datetime, timedelta
 
 from fastapi import APIRouter, HTTPException, Request
 from sqlalchemy.sql import select
@@ -51,7 +51,9 @@ def handle_user(user_id: uuid.UUID | None = None):
     description="Create a new session in the user db",
     response_model=dict,
 )
-def handle_session(user_id: uuid.UUID, request: Request, session_id: uuid.UUID | None = None):
+def handle_session(
+    user_id: uuid.UUID, request: Request, session_id: uuid.UUID | None = None
+):
     """
     Create a new session in the session db
     If session_id is provided, check if the session exists in the db and if the end_at is still more recent than time now

src/app/services/abst_chat.py

@@ -126,17 +126,15 @@ async def _detect_lang_with_llm(self, query: str) -> Dict[str, str]:
             },
         )
 
-        try:
-            assert isinstance(detected_lang, dict)
-
-            if detected_lang["ISO_CODE"] not in ["en", "fr"]:
-                raise LanguageNotSupportedError()
-
-            return detected_lang
-        except AssertionError:
-            logger.error("api_error=assertion_error, response=%s", detected_lang)
+        if isinstance(detected_lang, str):
+            jsn = extract_json_from_response(detected_lang)
+        elif isinstance(detected_lang, dict):
+            jsn = detected_lang
+        else:
             raise ValueError("Invalid response from model")
 
+        return jsn
+
     @log_time_and_error
     async def _detect_past_message_ref(
         self, query: str, history: List[Dict[str, str]]
@@ -385,7 +383,9 @@ async def chat_message(
         Returns:
             str: The chat message content.
         """
-        ISO_CODE = {"ISO_CODE": "en"}
+
+        # ISO_CODE = {"ISO_CODE": "en"}
+
         if should_check_lang:
             ISO_CODE = await self._detect_language(query)
 

src/app/services/prompts.py

@@ -159,7 +159,7 @@
 
 Audience: Computer program.
 
-Response: The response should be a single line with the following key-value structure: "ISO_CODE": "en"
+Response: The response should be in a JSON format with the following key-value structure: "ISO_CODE": "en"
 """
 
 

src/app/tests/api/api_v1/test_user.py

@@ -43,7 +43,9 @@ async def test_create_user_when_already_exists(self, session_maker_mock, *mocks)
             headers={"X-API-Key": "test"},
         )
         self.assertEqual(response.status_code, 200)
-        self.assertEqual(response.json(), {"user_id": "cfc8072c-a055-442a-9878-b5a73d9141b2"})
+        self.assertEqual(
+            response.json(), {"user_id": "cfc8072c-a055-442a-9878-b5a73d9141b2"}
+        )
 
     @mock.patch("src.app.api.api_v1.endpoints.user.session_maker")
     async def test_create_user_handles_exception(self, session_maker_mock, *mocks):
@@ -87,11 +89,16 @@ async def test_create_session_existing_valid_session(
 
         response = client.post(
             f"{settings.API_V1_STR}/user/session",
-            params={"user_id": "19f11fa7-87ef-40af-aa61-96a099bd04be", "session_id": "8178c3c4-9379-4997-a6e6-f1ccea7a30a9"},
+            params={
+                "user_id": "19f11fa7-87ef-40af-aa61-96a099bd04be",
+                "session_id": "8178c3c4-9379-4997-a6e6-f1ccea7a30a9",
+            },
             headers={"X-API-Key": "test"},
         )
         self.assertEqual(response.status_code, 200)
-        self.assertEqual(response.json(), {"session_id": "8178c3c4-9379-4997-a6e6-f1ccea7a30a9"})
+        self.assertEqual(
+            response.json(), {"session_id": "8178c3c4-9379-4997-a6e6-f1ccea7a30a9"}
+        )
 
     @mock.patch("src.app.api.api_v1.endpoints.user.session_maker")
     async def test_create_session_create_new_when_not_found(

src/app/tests/services/test_abst_chat.py

@@ -33,8 +33,6 @@ async def test_lang_ok(self, *mocks):
     async def test_lang_not_supported(self, *mocks):
         mocked_chat = {"ISO_CODE": "pt"}
         self.chat.chat_client.completion = mock.AsyncMock(return_value=mocked_chat)
-        with self.assertRaises(LanguageNotSupportedError):
-            await self.chat._detect_language("fake message")
 
         mocked_chat = "not json format"
         self.chat.chat_client.completion = mock.AsyncMock(return_value=mocked_chat)