don't send email before mentoring is validated

Author: samonaisi

apps/skills/views.py

@@ -735,7 +735,6 @@ def contact_mentor(self, request, *args, **kwargs):
             raise UserCannotMentorError
         serializer = MentorshipContactSerializer(data=request.data)
         serializer.is_valid(raise_exception=True)
-        self.send_email("contact_mentor", skill, **serializer.validated_data)
         try:
             Mentoring.objects.create(
                 skill=skill,
@@ -744,6 +743,7 @@ def contact_mentor(self, request, *args, **kwargs):
             )
         except IntegrityError:
             raise DuplicatedMentoringError
+        self.send_email("contact_mentor", skill, **serializer.validated_data)
         return Response(status=status.HTTP_204_NO_CONTENT)
 
     @extend_schema(request=MentorshipContactSerializer, responses={204: None})
@@ -764,7 +764,6 @@ def contact_mentoree(self, request, *args, **kwargs):
             raise UserDoesNotNeedMentorError
         serializer = MentorshipContactSerializer(data=request.data)
         serializer.is_valid(raise_exception=True)
-        self.send_email("contact_mentoree", skill, **serializer.validated_data)
         try:
             Mentoring.objects.create(
                 skill=skill,
@@ -773,4 +772,5 @@ def contact_mentoree(self, request, *args, **kwargs):
             )
         except IntegrityError:
             raise DuplicatedMentoringError
+        self.send_email("contact_mentoree", skill, **serializer.validated_data)
         return Response(status=status.HTTP_204_NO_CONTENT)