Skip to content

Fix: Match OS packages for stdlib #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 14, 2024
Merged

Fix: Match OS packages for stdlib #1309

merged 6 commits into from
Aug 14, 2024

Conversation

aryan-rajoria
Copy link
Collaborator

fixes issue #788, adds glibc-stdlib.json

Signed-off-by: Aryan Rajoria <[email protected]>
Signed-off-by: Aryan Rajoria <[email protected]>
@prabhu
Copy link
Collaborator

prabhu commented Aug 13, 2024

@aryan-rajoria are you planning to add the filtering logic as well in utils?

@aryan-rajoria
Copy link
Collaborator Author

@aryan-rajoria are you planning to add the filtering logic as well in utils?

yes I am adding that

Signed-off-by: Aryan Rajoria <[email protected]>
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
Copy link
Collaborator Author

Tested out the changes:
bom.json
(before the changes)
sbom2.json (after the changes)
Difference using custom-json-diff:
diffs2.json
diffs2.html.json

@aryan-rajoria aryan-rajoria marked this pull request as ready for review August 14, 2024 00:59
@aryan-rajoria aryan-rajoria requested a review from prabhu as a code owner August 14, 2024 00:59
@prabhu
Copy link
Collaborator

prabhu commented Aug 14, 2024

Can you update this README as well?

Signed-off-by: Aryan Rajoria <[email protected]>
@prabhu prabhu merged commit 593c490 into master Aug 14, 2024
24 of 25 checks passed
@prabhu prabhu deleted the addcppstdlib branch August 14, 2024 01:18
@prabhu prabhu added the lang:c label Aug 14, 2024
@prabhu
Copy link
Collaborator

prabhu commented Aug 14, 2024

Thank you so much for this wonderful PR! This should help filter out false positives in c/c++ projects.

@prabhu prabhu linked an issue Aug 14, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[c/c++] do not match OS packages for stdlib
2 participants