Fix DimPos being persisted under a hardcoded NBT key (#235)

Author: rubensworks

loader-neoforge/src/main/java/org/cyclops/cyclopscore/persist/nbt/NBTClassTypesNeoForge.java

@@ -40,7 +40,7 @@ public FluidStack getDefaultValue() {
 
             @Override
             public void writePersistedField(String name, DimPos object, ValueOutput tag) {
-                ValueOutput dimPos = tag.child("dim");
+                ValueOutput dimPos = tag.child(name);
                 dimPos.putString("dim", object.getLevel());
                 dimPos.putInt("x", object.getBlockPos().getX());
                 dimPos.putInt("y", object.getBlockPos().getY());
@@ -49,7 +49,10 @@ public void writePersistedField(String name, DimPos object, ValueOutput tag) {
 
             @Override
             public DimPos readPersistedField(String name, ValueInput tag) {
-                ValueInput dimPos = tag.child(name).orElseThrow();
+                ValueInput dimPos = tag.child(name)
+                        // Fallback for data that was written under a hardcoded key by older versions
+                        .or(() -> tag.child("dim"))
+                        .orElseThrow();
                 String dimensionName = dimPos.getString("dim").orElseThrow();
                 ResourceKey<Level> dimensionType = ResourceKey.create(Registries.DIMENSION, Identifier.parse(dimensionName));
                 return DimPos.of(dimensionType, new BlockPos(dimPos.getInt("x").orElseThrow(), dimPos.getInt("y").orElseThrow(), dimPos.getInt("z").orElseThrow()));