Crafting interface offset issues

[Anime37]

Issue type:

• 🐛 Bug

---

Short description:

I've noticed several issues with offset logic when it comes to crafting interfaces:

1. Offset tab doesn't appear in the UI upon upgrading the interface:

---

2. Using a wrench to save a new offset doesn't save the settings. Workaround is to modify some settings that are visible in UI and save for the offset to take effect;

3. Interface doesn't seem to be reading machine inventory data which the interface is targetting via offset - it reads the data from the machine it is directly connected to. For example, trying to input fluid into @oritech centrifuge leads to the fluid being put into the output slot instead.
   Tested by having an interface directly connected to the a machine and being offset to another same type of a machine to make sure this is the most likely case (input fluid goes into a correct machine and a correct slot when doing so):

Steps to reproduce the problem:

1. place a crafting interface which is facing an air block
2. add an offset upgrade to it
3. use a wrench to make the crafting interface point to a nearby machine/chest/etc.

Expected behaviour:

Offset upgraded crafting interfaces function like all the other connectors.

---

Versions:

• This mod: integratedcrafting-1.21.1-neoforge-1.2.3
• Minecraft: 1.13.2
• Mod loader version: NeoForge 21.1.194

Issue was first noticed by me in a modpack (Oceanblock 2), but kirjorjos in the discord suggested for me to create a ticket here nontheless.

[rubensworks]

Thanks for reporting!

[kirjorjos]

Can confirm 1 and 2 are also happening in my straight InDy testing instance:

• Integrated Crafting: 1.1.12
• Integrated Tunnels: 1.8.40
• Integrated Dynamics: 1.27.5
• Common Capabilities: 2.9.7
• Cyclops Core: 1.20.1
• Forge: 43.4.6
• Minecraft: 1.19.2

[rubensworks]

Indeed, offsets for crafting ifaces have not been implemented yet.
Merging this issue into #138.