Player Simulator with click item config spawn Air ItemEntity every tick

[pharuxtan]

Issue type:

• 🐛 Bug

---

Short description:

When using the Player Simulator with a Variable Card in the Click Item slot to right click a block with an item, it spawn an ItemEntity with minecraft:air every tick.

Steps to reproduce the problem:

1. Place a block that need to be right clicked with a non stackable item to work
2. Place a Logic Cable at a side of it
3. Connect a Player Simulator faced to the block
4. Add the Variable Card configured with the item needed for the right click interaction
5. Add a Chest at a side of the Logic Cable with your item needed in it
6. Add an Item Interface facing the chest from the Logic Cable
7. Check the nearest item entity tag with /data get entity @e[type=item,limit=1,sort=nearest], you should see an "Air" ItemEntity

Expected behaviour:

Player Simulator right clicking the block without any empty ItemEntity spawned in the world

---

Versions:

• This mod: Integrated Tunnels 1.9.0
• Minecraft: 1.21.1
• Mod loader version: NeoForge 21.1.209

Log file:

With KJS implementation to gather the stack trace of the spawned ItemEntity it gives this: https://hastebin.com/share/nolotugasi.bash

[rubensworks]

Thanks for reporting!

[rubensworks]

Place a block that need to be right clicked with a non stackable item to work

Could you specify which block exactly causes this problem, and what item you are clicking with?
Does this occur in vanilla? Or only for modded blocks/items?

[pharuxtan]

The Modpack Contained got problem with a Woot Revived automation related setup using the player simulator.

The block used was the Stygian Anvil, that needs the Stygian Hammer to craft with it (all from Woot Revived). The chest used to import the hammer was an obsidian chest iirc, but this element shouldn't matter that much.

[pharuxtan]

The problem probably comes from here https://github.com/CyclopsMC/IntegratedTunnels/blob/master-1.21-lts/src/main/java/org/cyclops/integratedtunnels/core/ItemStoragePlayerWrapper.java#L100

it spawns the remaining ItemStack, that might be empty

GitHub

IntegratedTunnels/src/main/java/org/cyclops/integratedtunnels/core/ItemStoragePlayerWrapper.java at master-1.21-lts · CyclopsMC/IntegratedTunnels

Transfer other energy, items and fluids over Integrated Dynamics networks - CyclopsMC/IntegratedTunnels

[rubensworks]

@pharuxtan Could you give some instructions on how the problem can be reproduced using this anvil? (a video is also an option)

The problem probably comes from here https://github.com/CyclopsMC/IntegratedTunnels/blob/master-1.21-lts/src/main/java/org/cyclops/integratedtunnels/core/ItemStoragePlayerWrapper.java#L100

That seems unlikely, since ItemStackHelpers.spawnItemStackToPlayer does nothing for empty itemstacks.
Do you have any indications to back this suspicion?

GitHub

IntegratedTunnels/src/main/java/org/cyclops/integratedtunnels/core/ItemStoragePlayerWrapper.java at master-1.21-lts · CyclopsMC/IntegratedTunnels

Transfer other energy, items and fluids over Integrated Dynamics networks - CyclopsMC/IntegratedTunnels

[pharuxtan]

https://www.youtube.com/watch?v=lreRoDso6sM here is the video! The server automatically kill the Air ItemEntity, but if the chunk is unloaded, it wont. So in the Contained Public Server it spawned a ton of Air ItemEntity, so many that it even created a entities/c.X.Z.mcc to store all these ItemEntities, and when you load back the chunk, the server kill them all. And mostly watchdog crash in the process because the process of killing all the entities takes server thread consumption.

- YouTube

Enjoy the videos and music you love, upload original content, and share it all with friends, family, and the world on YouTube.

[rubensworks]

Thanks!